Skip to content

feat(clerk-js,shared): getMemberships support for paginated responses + useOrganization adds memberships#1708

Merged
panteliselef merged 3 commits intomainfrom
ORG-211
Sep 14, 2023
Merged

feat(clerk-js,shared): getMemberships support for paginated responses + useOrganization adds memberships#1708
panteliselef merged 3 commits intomainfrom
ORG-211

Conversation

@panteliselef
Copy link
Copy Markdown
Contributor

@panteliselef panteliselef commented Sep 12, 2023

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

Description

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports

@panteliselef panteliselef self-assigned this Sep 12, 2023
@panteliselef panteliselef changed the title Org 211 feat(clerk-js,shared): getMemberships support for paginated responses + useOrganization adds memberships Sep 12, 2023
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Sep 13, 2023

🦋 Changeset detected

Latest commit: 8d1c340

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@clerk/clerk-js Patch
@clerk/shared Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/clerk-react Patch
@clerk/remix Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread .changeset/hot-chairs-refuse.md Outdated
Comment thread packages/types/src/organization.ts Outdated
@desiprisg
Copy link
Copy Markdown
Contributor

Does it make sense to add any tests for this change?

@panteliselef
Copy link
Copy Markdown
Contributor Author

Does it make sense to add any tests for this change?

@desiprisg there are no test for useOrganization at this moment. I will be adding them in a separate PR as it needs to cover all functionalities of the hook

@panteliselef panteliselef requested a review from a team as a code owner September 14, 2023 08:10
@panteliselef panteliselef merged commit 30bb9ec into main Sep 14, 2023
@panteliselef panteliselef deleted the ORG-211 branch September 14, 2023 08:19
@clerk-cookie clerk-cookie mentioned this pull request Sep 14, 2023
@clerk-cookie
Copy link
Copy Markdown
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants