chore(clerk-js): Upgrade floating-ui from 0.19 to 0.25#1726
Conversation
🦋 Changeset detectedLatest commit: dd81d09 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!snapshot |
|
Hey @LekoArts - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/backend
npm i @clerk/backend@0.29.1-snapshot.d446acb# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.4.0-snapshot.d446acb# @clerk/clerk-js
npm i @clerk/clerk-js@4.58.0-snapshot.d446acb# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.19.2-snapshot.d446acb# @clerk/fastify
npm i @clerk/fastify@0.6.7-snapshot.d446acb# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.4.8-snapshot.d446acb# @clerk/localizations
npm i @clerk/localizations@1.26.0-snapshot.d446acb# @clerk/nextjs
npm i @clerk/nextjs@4.24.0-snapshot.d446acb# @clerk/clerk-react
npm i @clerk/clerk-react@4.25.0-snapshot.d446acb# @clerk/remix
npm i @clerk/remix@2.10.3-snapshot.d446acb# @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.12.6-snapshot.d446acb# @clerk/shared
npm i @clerk/shared@0.22.1-snapshot.d446acb# @clerk/types
npm i @clerk/types@3.52.0-snapshot.d446acb |
| '@clerk/clerk-js': patch | ||
| --- | ||
|
|
||
| TODO |
There was a problem hiding this comment.
We probably only need an empty changeset for an internal change like this one :)
There was a problem hiding this comment.
I think we should bump the version because this upgrade contains breaking changes for floating-ui and thus can subtly change how things behave for our users.
While I did my extensive check into the changelog it still might change behavior and with having a release we can bisect it better. Publishing doesn't hurt here :)
There was a problem hiding this comment.
Thanks for explaining Lennart. Everything makes sense to me, let's go ahead and merge this one
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
4 participants
Description
The issue #1557 uncovered that when using
@clerk/nextjstogether withnext-intlthe error"Failed to execute 'removeChild' on 'Node'"was thrown.That error came from
@floating-ui/reactwhich@clerk/clerk-jsuses under the hood. Its version was upgraded from0.19.0to0.25.4to fix this error.I tested this by running the snapshot version in the reproduction repository and the issue didn't show up anymore.
Fixes #1557
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore