Conversation
🦋 Changeset detectedLatest commit: 3e1f0e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
octoper
force-pushed
the
vaggelis/js-723-weird-layout-shift-in-signin-social-buttons
branch
from
1a31fbd to
ba2c138
Compare
panteliselef
approved these changes
Sep 18, 2023
Contributor
panteliselef
left a comment
panteliselef
left a comment
There was a problem hiding this comment.
Seem like the loading spinner gets bigger. Can you confirm with @cedawson if that's ok ? Otherwise let's merge
anagstef
approved these changes
Sep 18, 2023
Contributor
|
Shall we merge this ? |
|
This looks good, thanks @octoper |
Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>
octoper
force-pushed
the
vaggelis/js-723-weird-layout-shift-in-signin-social-buttons
branch
from
ba2c138 to
3e1f0e1
Compare
octoper
deleted the
vaggelis/js-723-weird-layout-shift-in-signin-social-buttons
branch
Merged
Collaborator
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added some padding when the
ArrowBlockButtonis in loading state and has a left icon to prevent layout shift.fixes JS-723
Before
JS-723-before.mp4
After
JS-723-after.mp4
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore