Skip to content

fix(clerk-js,localizations,types): Add formFieldError__verificationLinkExpired key#1738

Merged
LekoArts merged 3 commits intomainfrom
lekoarts/js-739-verification-link-expired-text-is-not-localizable
Sep 18, 2023
Merged

fix(clerk-js,localizations,types): Add formFieldError__verificationLinkExpired key#1738
LekoArts merged 3 commits intomainfrom
lekoarts/js-739-verification-link-expired-text-is-not-localizable

Conversation

@LekoArts
Copy link
Copy Markdown
Contributor

@LekoArts LekoArts commented Sep 18, 2023

Description

This PR replaces The verification link expired. Please resend it. with the localization key formFieldError__verificationLinkExpired. I adjusted the message a little bit to make it clearer to The verification link expired. Please request a new link.

I also added the german translation since that's my mother tongue 😆

Fixes #1711

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Sep 18, 2023

🦋 Changeset detected

Latest commit: 12fb35e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LekoArts LekoArts marked this pull request as ready for review September 18, 2023 11:30
@LekoArts LekoArts requested a review from a team as a code owner September 18, 2023 11:30
@LekoArts LekoArts merged commit 01b024c into main Sep 18, 2023
@LekoArts LekoArts deleted the lekoarts/js-739-verification-link-expired-text-is-not-localizable branch September 18, 2023 14:07
@clerk-cookie clerk-cookie mentioned this pull request Sep 18, 2023
@clerk-cookie
Copy link
Copy Markdown
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verification link expired text is not localizable

5 participants