Documentation of `retest` doesn't seem correct?

[marcomorain]

The documentation of the retest command doesn't seem correct.

Return exception cause and stack frame info for an erring test via the stacktrace middleware. The error to be retrieved is referenced by namespace, var name, and assertion index within the var.

The Cider docs say this:

Re-run test failures/errors.

The retest will re-run any tests that failed in the previous test run, right?

[vemv]

Right, retest does exactly the following:

cider-nrepl/src/cider/nrepl/middleware/test.clj

Lines 352 to 368 in a898e40

	(defn handle-retest-op
	[{:keys [transport session id] :as msg}]
	(let [{:keys [exec]} (meta session)]
	(exec id
	(fn []
	(with-bindings (assoc @session #'ie/*msg* msg)
	(let [nss (reduce (fn [ret [ns tests]]
	(let [problems (filter (comp #{:fail :error} :type)
	(mapcat val tests))
	vars (distinct (map :var problems))]
	(if (seq vars) (assoc ret ns vars) ret)))
	{} @results)
	report (test-nss nss)]
	(reset! results (:results report))
	(t/send transport (response-for msg (util/transform-value report))))))
	(fn []
	(t/send transport (response-for msg :status :done))))))

The most relevant bit being (test-nss ,,,.

Which contradicts https://docs.cider.mx/cider-nrepl/nrepl-api/ops.html#retest and indeed seems worth fixing.

[bbatsov]

Seems we made a classic copy/paste mistake. :-)

[vemv]

Fixed recently