Skip to content

Conversation

@rksm
Copy link
Member

@rksm rksm commented Apr 12, 2021

I believe that this fixes #15. I'll test this some and would invite others testing as well.

@rksm rksm force-pushed the rksm/shadow-cljs-fix branch from da3cdec to ba6d937 Compare April 12, 2021 02:55
Copy link
Collaborator

@arichiardi arichiardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - haven't tried it though

@bbatsov
Copy link
Member

bbatsov commented Apr 13, 2021

Looks good to me as well - at the very least this is no longer going to blow up with shadow, even if it turns out the completion doesn't work properly. I guess @thheller can potentially confirm if we're using the right shadow-cljs API right now.

Other than this - seems you've reflowed the entire README (I see most like breaks are gone), so it's hard to understand what are the documentation changes, but I'll assume those are fine.

I was thinking it will be nice if there was a section in the docs about hacking on suitable - should be useful to potential contributors.

@bbatsov
Copy link
Member

bbatsov commented Apr 13, 2021

One more thing - if this API didn't exist before shadow 2.10, we should probably guard against this and just return an empty list of candidates.

@thheller
Copy link

LGTM. I'll make sure that cljs-eval API fn stays alive and functional.

@rksm
Copy link
Member Author

rksm commented Apr 17, 2021

@bbatsov the pure diff of README.md, only minor changes. Sorry the line breaks did bother me.

Screen Shot 2021-04-18 at 1 42 18 AM

@rksm rksm force-pushed the rksm/shadow-cljs-fix branch from c554891 to 8472261 Compare April 17, 2021 23:46
@rksm rksm force-pushed the rksm/shadow-cljs-fix branch 2 times, most recently from 0c96b04 to d52351c Compare April 18, 2021 00:09
@bbatsov bbatsov merged commit 223f890 into master Apr 18, 2021
@bbatsov bbatsov deleted the rksm/shadow-cljs-fix branch April 18, 2021 04:44
@bbatsov
Copy link
Member

bbatsov commented Apr 18, 2021

I saw you already cut 0.4, so I guess it's time to merge this branch. Big thanks for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shadow-cljs support broken in 2.10.+

5 participants