clojure-test-maybe-enable issue

[edgargoncalves]

Hi! Is it my impression, or the current definition of the clojure-test-maybe-enable has two setbacks?

• First, it doesn't do anything related to the directory the file is in, unlike the docstring statement.
• Second, the check it does will search for "clojure.test" on the file - isn't that somehow limitative (despite the fact that it won't be a good detection method, if the file contains that string in a comment somewhere else besides the namespace, e.g. ...)

I propose the following change, as it works for - what i believe to be - the right way to specify tests:

(defun clojure-test-maybe-enable ()
  "Enable clojure-test-mode if the current buffer contains a namespace 
   with a \"test.\" bit on it."
  (let ((ns (clojure-find-package))) ; defined in clojure-mode.el
    (when (search "test." ns)
  (clojure-test-mode t))))

What do you think?

[technomancy]

Sounds good! I originally had it search for clojure.test because you can write tests in the same buffer as the implementation by attaching :test metadata to your defns, but it seems like nobody really does that. So this seems like a better way to do it. Thanks.

[edgargoncalves]

Great! You're right, for my part, at least, I often forget I can include them as metadata :) Also, reading the code for most of the libraries available on GitHub, people "learn" that having a separate test directory is the preferred way.

I actually have a couple more additions to the workflow in question, because I usually want to jump to another window (keeping both source and tests visible). I know some prefer to code on each mode separately, so I wouldn't make this the default behavior - but it's easy to change on each own's emacs configuration! So, for sake of future readers who happen to like doing the same, here are my "advices":

(defadvice clojure-jump-to-test (before edgar-open-on-other-window () activate)
  (find-file-other-window (buffer-file-name)))

(defadvice clojure-test-jump-to-implementation (before edgar-on-other-window () activate)
  (find-file-other-window (buffer-file-name)))

I also made a clojure-jump-to-test replacement that (1) creates a test file namespace skeleton when needed and (2) jumps to the deftest named test-MY-FUNC, or creates a skeleton for it (MY-FUNC is the defn your cursor is on, at the moment, in the source file). Again, I wouldn't force people to use tests this way - naming a test after each function may not be the best way to do them (e.g., you may want use-cases names). So don't make this the default behavior, but feel free to include as an alternative (it does save a lot of time and "feels" like a better IDE action to me!):

(defun clojure-jump-to-function-test ()
  (interactive)
  (flet ((maybe-create-test-namespace
    (namespace)
    (unless (clojure-find-package)
      (goto-char (point-min))
      (insert (format "(ns %s\n  (:use [%s] [clojure.test]))\n\n"
              (replace-regexp-in-string "\\(\\.\\)[^\\.]+$" ".test." namespace nil nil 1)
              namespace)))))
  (let* ((fn (which-function))
   (fn-name (if (listp fn) (first fn) fn))
   (namespace (clojure-find-package)))
    (clojure-jump-to-test)
    (when fn-name
      (goto-char (point-min))
      (maybe-create-test-namespace namespace)
      (unless (search-forward-regexp (format "(deftest test-%s[ \t\n]*" fn-name) nil t)
        (goto-char (point-max))
        (insert (format "\n\n(deftest test-%s\n  )" fn-name))
        (goto-char (- (point) 1)))))))

(define-key clojure-mode-map (kbd "C-c t") 'clojure-jump-to-function-test)

Cheers