Require package #4

mwfogleman · 2015-01-12T19:47:32Z

Based on @purcell's comments in #3.

expez · 2015-01-12T20:00:58Z

This looks good. Are you still working on this branch or do you want me to merge it in so you can base the other pr on master?

mwfogleman · 2015-01-12T20:04:32Z

@expez I'd like to
a) have someone else run it and make sure everything still works.
b) have someone tell me that everything in site-lisp needs to be there (that is, needs to be there for clj-refactor)

Then I'd like to squash the commit.

Come to think of it, is it really true that we need a non-stable clj-refactor? It says on the project page that it is on MELPA stable.

expez · 2015-01-12T20:07:22Z

melpa stable is pretty damn old for clj-refactor. We want to get 1.0 out the door with a gazillion new features, but we also want to make sure it's actually worth using.

expez · 2015-01-12T20:11:41Z

Looks to me like company, epl and pkg-info can be deleted.

Unfortunately I don't have time to try this out atm, I have to run.

benedekfazekas · 2015-01-12T20:29:52Z

i think we need company for completion in cider tho
On 12 Jan 2015 20:11, "Lars Andersen" notifications@github.com wrote:

Looks to me like company, epl and pkg-info can be deleted.

—
Reply to this email directly or view it on GitHub
#4 (comment)
.

arrdem · 2015-01-12T20:34:04Z

We do.

expez · 2015-01-12T21:08:38Z

If cider is installed by the package manager then so are its deps.

purcell · 2015-01-12T21:28:41Z

If cider is installed by the package manager then so are its deps.

cider doesn't depend on company. There would need to be a separate (require-package 'company) to ensure it gets installed.

benedekfazekas · 2015-01-12T21:31:25Z

not sure company is a cider dependency. u still need it if u want proper
completion tho
On 12 Jan 2015 21:08, "Lars Andersen" notifications@github.com wrote:

If cider is installed by the package manager then so are its deps.

—
Reply to this email directly or view it on GitHub
#4 (comment)
.

benedekfazekas · 2015-01-12T22:18:50Z

happy to test this tmrw morning. can't do this evening unfortunately

ghost · 2015-01-12T22:21:55Z

i will also test tomorrow

expez · 2015-01-13T06:58:35Z

right, forgot about company being a soft dependency for cider, but why not install company as well through the package manager?

benedekfazekas · 2015-01-13T10:37:48Z

tested with 24.3 and 24.4. essentially the inital require package works fine at startup. there is one issue tho and two request:

apparently this line (add-to-list 'load-path (concat user-emacs-directory "site-lisp")) does not really work. I had to add all directories under .emacs.d/site-lisp to the load path to make clj-refactor work. I know this is suboptimal (lovely word 'suboptimal') but there is a good reason, see @expez and my previous comments
could you pls extend the 'Using Emacs package management' section in README specially explaining what happens at first start up
exec-path-from-shell comes from stable now init.el initial comment needs fixing.

ta!

mwfogleman · 2015-01-13T14:40:22Z

I'll fix those things soon, @benedekfazekas.

My last commit anticipated @expez's suggestion, and does a require-package on company, too.

How would we feel about doing that with all of clj-refactor's dependencies (if they are available on MELPA stable)?

benedekfazekas · 2015-01-13T14:44:17Z

that is cool for company.

but as @expez said above unfortunately melpa stable has a dated clj-refactor version. as soon as clj-refactor 1.0.0 released to melpa stable i will get rid of the ugly load path hacking here i promise ;)

hope this answers your question. ta for the good work

mwfogleman · 2015-01-13T14:45:35Z

@benedekfazekas, sorry, I meant doing the same for everything but clj-refactor and anything else that we need an unstable version of.

From a first glance on Melpa stable, It looks like that'd be everything but clj-refactor and s.el.

benedekfazekas · 2015-01-13T14:48:35Z

yeah just reread your comment and realised i misunderstood. sry. yeah right, why not: perhaps mark them in comment that they are dependencies of refactor? (so i can remove them easily when we can do proper require-package for clj-refactor)

mwfogleman · 2015-01-13T14:51:27Z

OK, I'll try to add a comment about that. And it looks like we need to grab yasnippet manually, too. So I'll keep that, s.el, and clj-refactor.

benedekfazekas · 2015-01-13T14:51:50Z

sounds like a good middleground. thx

mwfogleman · 2015-01-13T15:27:44Z

OK, I think this should be functional and ready to go (after a squash or two).

I took the liberty of taking my big red pen to the README in the last commit.

ghost · 2015-01-13T15:40:15Z

I just downloaded your latest commit @mwfogleman from your branch, made it my .emacs.d/ dir (after having previously renamed my existing .emacs.d to a backup) and opened my Emacs 24.3.1 on OSX. The following warnings/errors occurred:

Warning (emacs): Unable to activate package pkg-info'. Required packagedash-1.6.0' is unavailable
Warning (initialization): An error occurred while loading `/Users/hellofunk/.emacs.d/init.el':

File error: Cannot open load file, clj-refactor

To ensure normal operation, you should investigate and remove the
cause of the error in your initialization file. Start Emacs with
the `--debug-init' option to view a complete error backtrace.

mwfogleman · 2015-01-13T15:42:10Z

OK, thanks for testing @hellofunk! Not sure what the problem is but I'll look into it.

benedekfazekas · 2015-01-13T15:42:15Z

yup, same here: no joy. this works for me tho (tested both 24.3 and 24.4):

(add-to-list 'load-path (concat user-emacs-directory "site-lisp/s-20140910.334"))
(add-to-list 'load-path (concat user-emacs-directory "site-lisp/yasnippet-20141223.303"))
(add-to-list 'load-path (concat user-emacs-directory "site-lisp/clj-refactor-20150104.1358"))

mwfogleman · 2015-01-13T15:43:05Z

@benedekfazekas Aha, I forgot the /. My bad. Pushed an update.

ghost · 2015-01-13T15:49:16Z

These various issues and warnings that have popped up in the building of this example config certainly validate the need for this config in the first place! If you seasoned emacs users have problems with this stuff, imagine how nearly impossible it is for a newbie to get it all going! @mwfogleman I till try your latest right now.

benedekfazekas · 2015-01-13T15:55:01Z

all good. will merge as soon as you squash. special thx for big red pen corrections ;)

@purcell

This commit uses @purcell's suggestion to automatically download and install packages where possible and desirable. It uses the "require-function" helper to do so. This commit also delete packages that now use require-package, moves the remaining manual installs to site-lisp, and updates the README.md to talk about require-package.

ghost · 2015-01-13T15:58:05Z

hm, still having errors.

i simply downloaded the zip file from here:

https://github.com/mwfogleman/example-config/tree/require-package

right place?

i still get these errors on emacs startup:

pkg-info.el:48:1:Error: Cannot open load file: dash
Warning (emacs): Unable to activate package pkg-info'. Required packagedash-1.6.0' is unavailable

however, when I closed emacs and then started it again, there were no errors reported.

benedekfazekas · 2015-01-13T15:59:27Z

i've seen that error pop up now and then but cljrefactor and cider was still functional (they use dash i think) so i guess nothing to worry about...

mwfogleman · 2015-01-13T16:00:32Z

I squashed my commits.

Require package

mwfogleman force-pushed the require-package branch from ad52126 to 9c9d488 Compare January 12, 2015 20:46

mwfogleman mentioned this pull request Jan 12, 2015

Add flycheck and flycheck-clojure. #3

Merged

README pruning.

e898688

mwfogleman force-pushed the require-package branch from 25c729f to e898688 Compare January 13, 2015 15:58

benedekfazekas added a commit that referenced this pull request Jan 13, 2015

Merge pull request #4 from mwfogleman/require-package

8648cda

Require package

benedekfazekas merged commit 8648cda into clojure-emacs:master Jan 13, 2015

Require package #4

Require package #4

Uh oh!

Conversation

mwfogleman commented Jan 12, 2015

Uh oh!

expez commented Jan 12, 2015

Uh oh!

mwfogleman commented Jan 12, 2015

Uh oh!

expez commented Jan 12, 2015

Uh oh!

expez commented Jan 12, 2015

Uh oh!

benedekfazekas commented Jan 12, 2015

Uh oh!

arrdem commented Jan 12, 2015

Uh oh!

expez commented Jan 12, 2015

Uh oh!

purcell commented Jan 12, 2015

Uh oh!

benedekfazekas commented Jan 12, 2015

Uh oh!

benedekfazekas commented Jan 12, 2015

Uh oh!

ghost commented Jan 12, 2015

Uh oh!

expez commented Jan 13, 2015

Uh oh!

benedekfazekas commented Jan 13, 2015

Uh oh!

mwfogleman commented Jan 13, 2015

Uh oh!

benedekfazekas commented Jan 13, 2015

Uh oh!

mwfogleman commented Jan 13, 2015

Uh oh!

benedekfazekas commented Jan 13, 2015

Uh oh!

mwfogleman commented Jan 13, 2015

Uh oh!

benedekfazekas commented Jan 13, 2015

Uh oh!

mwfogleman commented Jan 13, 2015

Uh oh!

ghost commented Jan 13, 2015

Uh oh!

mwfogleman commented Jan 13, 2015

Uh oh!

benedekfazekas commented Jan 13, 2015

Uh oh!

mwfogleman commented Jan 13, 2015

Uh oh!

ghost commented Jan 13, 2015

Uh oh!

benedekfazekas commented Jan 13, 2015

Uh oh!

ghost commented Jan 13, 2015

Uh oh!

benedekfazekas commented Jan 13, 2015

Uh oh!

mwfogleman commented Jan 13, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants