Skip to content

Support Persistent/VECTOR in a backwards compatible way #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2025
+23 −14
Merged

Support Persistent/VECTOR in a backwards compatible way #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 23 additions & 14 deletions src/main/clojure/cljs/analyzer.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1313,6 +1313,10 @@
{:name sym}
lb))

(defn qualified->dotted
[sym]
(symbol (str (namespace sym) "." (name sym))))

(defn resolve-var
"Resolve a var. Accepts a side-effecting confirm fn for producing
warnings about unresolved vars."
Expand Down Expand Up @@ -1356,20 +1360,25 @@
(some? lb) (assoc lb :op :local)

(some? (namespace sym))
(let [ns (namespace sym)
ns (if #?(:clj (= "clojure.core" ns)
:cljs (identical? "clojure.core" ns))
"cljs.core"
ns)
full-ns (resolve-ns-alias env ns
(or (and (js-module-exists? ns)
(gets @env/*compiler* :js-module-index ns :name))
(symbol ns)))]
(when (some? confirm)
(when (not= current-ns full-ns)
(confirm-ns env full-ns))
(confirm env full-ns (symbol (name sym))))
(resolve* env sym full-ns current-ns))
(let [ns (namespace sym)]
(if-let [resolved (and (nil? (resolve-ns-alias env ns nil))
(not (dotted-symbol? ns))
(resolve-var env (symbol ns) nil false)
(resolve-var env (qualified->dotted sym) nil false))]
resolved
(let [ns (if #?(:clj (= "clojure.core" ns)
:cljs (identical? "clojure.core" ns))
"cljs.core"
ns)
full-ns (resolve-ns-alias env ns
(or (and (js-module-exists? ns)
(gets @env/*compiler* :js-module-index ns :name))
(symbol ns)))]
(when (some? confirm)
(when (not= current-ns full-ns)
(confirm-ns env full-ns))
(confirm env full-ns (symbol (name sym))))
(resolve* env sym full-ns current-ns))))

(dotted-symbol? sym)
(let [idx (.indexOf s ".")
Expand Down