Skip to content

Support arbitrary db-spec k/vs from query params in URIs. #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2014
Merged

Support arbitrary db-spec k/vs from query params in URIs. #35

merged 2 commits into from
Jan 21, 2014

Conversation

technomancy
Copy link
Contributor

This makes it a lot easier to support SSL connections from URI-style DB connection parameters.

@technomancy
Support arbitrary db-spec k/vs from query params in URIs.
f16a054 
This makes it a lot easier to support SSL connections from URI-style
DB connection parameters.
@seancorfield
Copy link
Member

Seems like a nice addition. Want to add at least one test for it? Or at least enhance some of the existing tests around URI parsing?

@technomancy
Copy link
Contributor Author

Sure thing; I will add some tests.

@technomancy
Add explict tests for URI-style DB specs.
fba097f 
Note that there is some redundancy here since URI specs may be tested
by `postgres-str-db` and friends, but it wasn't clear how those are
invoked in the test suite as it is, so I've left them alone even
though they appear unnecessary.
@technomancy
Copy link
Contributor Author

There we go; that should cover the changed behaviour. Though as per the commit message there is some redundancy remaining that I wasn't sure what to do about.

seancorfield added a commit that referenced this pull request Jan 21, 2014
@seancorfield
Merge pull request #35 from technomancy/query-params-on-uri
61afd13 
Support arbitrary db-spec k/vs from query params in URIs.
@seancorfield seancorfield merged commit 61afd13 into clojure:master Jan 21, 2014
@seancorfield
Copy link
Member

Thank you sir!

@seancorfield
Copy link
Member

FWIW, the PostgreSQL-specific tests can only be triggered by environment variables when running tests, and PostgreSQL isn't tested by default (I test H2, SQLite, Derby, MySQL, MS SQL Server and the jTDS SQL Server driver locally; only the first three are tested by build.clojure.org).

@technomancy
Copy link
Contributor Author

Thanks!

Yeah, I see where the env var is specified in the readme now. But I can't tell whether things like postgres-str-db is meant to be treated as a distinct DB using that env var; I feel like that should probably be removed but didn't want to do it myself since I wasn't sure how it was tested in CI. No matter; thanks for merging.

@technomancy technomancy deleted the query-params-on-uri branch January 21, 2014 22:44
@seancorfield
Copy link
Member

Good point. I should clean up the README around how to run the tests. You can either use TEST_DBS=postgres or TEST_DBS=postgres-str I believe as I think the mysql / mysql-str tests work that way but I'd have to actually run it to be sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@technomancy @seancorfield