pci: vfio: Fix and clarify BAR calculation code #2821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbradford
force-pushed
the
2021-07-02-fix-vfio-bar-calculation
branch
from
34b8ac6 to
13952bc
Compare
The BAR calculation code was incorrect for calculating I/O BARs but also has misleading comments (mixing bits and bytes, first and least significant, etc). This change adjusts the algorithm to more closely match the version described in the PCI specification and takes advantage of Rust's binary literals for ease of reading. Although this is slightly longer by calculating the 64-bit and 32-bit paths separately I think this is easier to read. Signed-off-by: Rob Bradford <robert.bradford@intel.com>
rbradford
force-pushed
the
2021-07-02-fix-vfio-bar-calculation
branch
from
13952bc to
23a78c5
Compare
sboeuf
reviewed
Jul 5, 2021
Yup, it went green. |
rbradford
force-pushed
the
2021-07-02-fix-vfio-bar-calculation
branch
from
fdcd0f6 to
23a78c5
Compare
sboeuf
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BAR calculation code was incorrect for calculating I/O BARs but also
has misleading comments (mixing bits and bytes, first and least
significant, etc).
This change adjusts the algorithm to more closely match the version
described in the PCI specification and takes advantage of Rust's binary
literals for ease of reading. Although this is slightly longer by
calculating the 64-bit and 32-bit paths separately I think this is
easier to read.
Signed-off-by: Rob Bradford robert.bradford@intel.com