hypervisor: kvm/x86_64: get and set nested guest state #7380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
nested-state-migration
branch
from
197ab59 to
bf80750
Compare
phip1611
force-pushed
the
nested-state-migration
branch
from
bf80750 to
247d672
Compare
rbradford
reviewed
Sep 25, 2025
Since the functionality of [0] was backported to kvm-bindings@v0.12.1 and kvm-ioctls@v0.22.1 [1, 2], we can now save nested KVM state. This way, nesting works across state save/resume and live-migration. [0] rust-vmm/kvm#322 [1] rust-vmm/kvm#349 [2] rust-vmm/kvm#350 Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de> On-behalf-of: SAP philipp.schuster@sap.com
phip1611
force-pushed
the
nested-state-migration
branch
from
247d672 to
05cdfa3
Compare
RuoqingHe
reviewed
Sep 29, 2025
| /// Get the state of the nested guest from the current vCPU, | ||
| /// if there is any. | ||
| #[cfg(target_arch = "x86_64")] | ||
| fn nested_state(&self) -> cpu::Result<Option<KvmNestedStateBuffer>> { |
There was a problem hiding this comment.
Maybe nested_state -> get_nested_state 🙂
There was a problem hiding this comment.
By convention, Rust code should avoid a get_ where possible. In kvm-ioctls, this only exists for consistence with the rest of the code. I don't have a strong opinion here, tho.
rbradford
approved these changes
Sep 29, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the functionality of [0] was backported to
kvm-bindings@v0.12.1andkvm-ioctls@v0.22.1[1, 2], we can now save nested KVM state. This way, nesting works across state save/resume and live-migration.[0] rust-vmm/kvm#322
[1] rust-vmm/kvm#349
[2] rust-vmm/kvm#350
Closes #7160 (makes it obsolete).