- 
                Notifications
    You must be signed in to change notification settings 
- Fork 11
feat(TaskProcessing): Add trigger_handler to set_handlers() #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for trigger handlers in the FastAPI integration by introducing a new trigger_handler parameter to the set_handlers() function. This enables handling of task processing trigger events from AppAPI.
- Adds trigger_handlerparameter toset_handlers()function
- Implements automatic FastAPI endpoint registration for trigger callbacks
- Provides documentation for the new trigger handler functionality
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
af3abaa    to
    254936c      
    Compare
  
    254936c    to
    ba1c542      
    Compare
  
    ba1c542    to
    e5ce40a      
    Compare
  
    | What do you think about passing  | 
| 
 Mh, no opnion, either is good for me, I think. What would be the benefit of having it in the URL path? | 
| Linters only complains for two things: 
 We can fix second option with  
 Not sure that this will work for FastAPI for query params - I know that this works for  I am fine with any type of fix, even with adding  Other Pylint error that is not related to this PR I already fixed in the  | 
e5ce40a    to
    40c89a9      
    Compare
  
    Signed-off-by: Marcel Klehr <mklehr@gmx.net>
95b668d    to
    c77caaa      
    Compare
  
    for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
| Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
- Coverage   95.11%   94.93%   -0.18%     
==========================================
  Files          45       45              
  Lines        5361     5371      +10     
==========================================
  Hits         5099     5099              
- Misses        262      272      +10     
 🚀 New features to boost your workflow:
 | 
See nextcloud/app_api#683 for the corresponding AppAPI PR.
Changes proposed in this pull request:
trigger_handlerparam to set_handlers() that will be called when the /trigger endpoint is requested by AppAPI.