feat: send cookies

Author: AndreyTheWeb

src/features/import-profile/extensions/model.ts

@@ -1,12 +1,15 @@
 import { createEvent, createStore } from 'effector';
 
-import { Extensions } from '#shared/constants';
-
 export const profileImportExtensionNameChanged = createEvent<string>();
 export const profileImportExtensionNameCleared = createEvent();
 export const profileImportExtensionNameReset = createEvent();
 
-export const $profileImportExtensionName = createStore<string | null>(Extensions.ModHeader)
+// Defaults to `null` so the regular "Import profile" flow never runs an extension adapter.
+// The "Import from other extension" modal selects a concrete extension on mount (see
+// ImportFromExtensionModal). This avoids a race: the wiring that clears the name on
+// `importModalOpened` lives in a lazily-loaded chunk and may not be registered yet when the modal
+// opens, so a ModHeader default leaked into plain imports and crashed the ModHeader adapter.
+export const $profileImportExtensionName = createStore<string | null>(null)
   .on(profileImportExtensionNameChanged, (_, string) => string)
   .on(profileImportExtensionNameCleared, () => null)
   .reset(profileImportExtensionNameReset);

src/features/import-profile/utils/validateProfileList.ts

@@ -1,4 +1,4 @@
-import { Profile, RequestHeader } from '#entities/request-profile/types';
+import { Profile, RequestCookie, RequestHeader } from '#entities/request-profile/types';
 import { generateIdWithExcludeList } from '#shared/utils/generateId';
 
 export function validateProfileList(profileList: Profile[], existingProfileList: Profile[]) {
@@ -45,6 +45,32 @@ export function validateProfileList(profileList: Profile[], existingProfileList:
       }
     });
 
+    if (profile.requestCookies !== undefined && !Array.isArray(profile.requestCookies)) {
+      throw new Error(`The profile ${currentProfileNumber} "requestCookies" value must be an array`);
+    }
+
+    (profile.requestCookies ?? []).forEach((cookie: Partial<RequestCookie>, cookieIndex: number) => {
+      const currentCookieNumber = cookieIndex + 1;
+
+      if (typeof cookie.name !== 'string') {
+        throw new Error(
+          `The cookie ${currentCookieNumber} in profile ${currentProfileNumber} must have a string "name" value`,
+        );
+      }
+
+      if (typeof cookie.value !== 'string') {
+        throw new Error(
+          `The cookie ${currentCookieNumber} in profile ${currentProfileNumber} must have a string "value" value`,
+        );
+      }
+
+      if (typeof cookie.disabled !== 'boolean') {
+        throw new Error(
+          `The cookie ${currentCookieNumber} in profile ${currentProfileNumber} must have a boolean "disabled" value`,
+        );
+      }
+    });
+
     existingProfileList.forEach((existingProfile, existingProfileIndex) => {
       const currentExistingProfileNumber = existingProfileIndex + 1;
 
@@ -74,6 +100,9 @@ export function generateProfileList(profileList: Profile[], existingProfileList:
   const existingProfileRequestHeadersListId = existingProfileList.flatMap(profile =>
     profile.requestHeaders.map(header => header.id),
   );
+  const existingProfileRequestCookiesListId = existingProfileList.flatMap(profile =>
+    (profile.requestCookies ?? []).map(cookie => cookie.id),
+  );
 
   return profileList.map(profile => ({
     ...profile,
@@ -82,6 +111,10 @@ export function generateProfileList(profileList: Profile[], existingProfileList:
       ...header,
       id: generateIdWithExcludeList(existingProfileRequestHeadersListId),
     })),
+    requestCookies: (profile.requestCookies ?? []).map((cookie: RequestCookie) => ({
+      ...cookie,
+      id: generateIdWithExcludeList(existingProfileRequestCookiesListId),
+    })),
     urlFilters: profile.urlFilters || [],
   }));
 }

src/widgets/modals/components/ImportFromExtensionModal/ImportFromExtensionModal.tsx

@@ -46,6 +46,16 @@ export function ImportFromExtensionModal() {
 
   const textFieldRef = useRef<HTMLTextAreaElement>(null);
 
+  // Preselect ModHeader when opening the modal without a chosen extension. Done here (not via a
+  // store default) so the plain "Import profile" flow keeps a `null` extension name and never runs
+  // an adapter.
+  useEffect(() => {
+    if (!profileImportExtensionName) {
+      onProfileImportExtensionNameChanged(Extensions.ModHeader);
+    }
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, []);
+
   useEffect(() => {
     if (isError && textFieldRef.current) {
       textFieldRef.current.focus();

tests/e2e/profiles.spec.ts

@@ -106,13 +106,10 @@ test.describe('Profile Actions', () => {
     const profilesBefore = page.locator('[data-test-id="profile-select"]');
     const countBefore = await profilesBefore.count();
 
-    // Open the profile actions menu
-    await openProfileActionsMenu(page);
-
-    // Select "Delete profile"
-    const deleteOption = page.getByRole('menuitem', { name: 'Delete profile' });
-    await expect(deleteOption).toBeVisible({ timeout: 5000 });
-    await deleteOption.click();
+    // Delete the selected profile via the dedicated trash button
+    const removeProfileButton = page.locator('[data-test-id="remove-profile-button"]');
+    await expect(removeProfileButton).toBeEnabled({ timeout: 5000 });
+    await removeProfileButton.click();
 
     // Wait for the profile to be removed
     const profilesAfter = page.locator('[data-test-id="profile-select"]');
@@ -228,19 +225,25 @@ test.describe('Profile Actions', () => {
     const jsonTextarea = page.locator('[data-test-id="import-profile-json-textarea"] textarea');
     await expect(jsonTextarea).toBeVisible({ timeout: 10000 });
 
+    // Mirror the real export/import shape: profiles carry no id/name, and headers/cookies/filters
+    // are stored without ids (ids are regenerated on import).
     const importJson = JSON.stringify([
       {
-        id: 'imported-profile-1',
-        name: 'Imported Profile',
+        urlFilters: [],
         requestHeaders: [
           {
-            id: 1,
             name: 'X-Imported-Header',
             value: 'imported-value',
             disabled: false,
           },
         ],
-        urlFilters: [],
+        requestCookies: [
+          {
+            name: 'imported_session',
+            value: 'cookie-value-123',
+            disabled: false,
+          },
+        ],
       },
     ]);
 
@@ -253,6 +256,13 @@ test.describe('Profile Actions', () => {
     // Verify that the profile was imported (check header input)
     const headerNameField = page.locator('[data-test-id="header-name-input"] input');
     await expect(headerNameField.first()).toHaveValue('X-Imported-Header', { timeout: 5000 });
+
+    // Verify that the imported request cookies were applied as well
+    await page.getByRole('tab', { name: 'Request cookies' }).click();
+    const cookieNameField = page.locator('[data-test-id="cookie-name-input"] input');
+    const cookieValueField = page.locator('[data-test-id="cookie-value-input"] input');
+    await expect(cookieNameField.first()).toHaveValue('imported_session', { timeout: 5000 });
+    await expect(cookieValueField.first()).toHaveValue('cookie-value-123');
   });
 
   /**