Control if next & previous actions are allowed in the fast API adapter

- Fix connectPortalRoutes named export

Author: arnaugiralt

components/src/index.js

@@ -18,7 +18,7 @@ export { default as store } from '~core/store';
 export { default as bus } from '~core/eventBus';
 
 export {
-  connectPortalRoutesDict as connectPortalRoutesDict,
+  connectPortalRoutesDict as connectPortalRoutes,
 } from '~constants/portal-routes';
 
 export default (widgets = {}, options = {}) => {

tools/api/fastApi/adapter.js

@@ -54,18 +54,22 @@ export const fastApiTableAdapter = (endpoint, rowsPerPage = 10) => {
   };
 
   /**
-   * @returns {Promise<{total: number, page: number, items: *[]}>}
+   * @returns {{total: number, page: number, items: *[]}|Promise<{total: number, page: number, items: *[]}>}
    */
   const next = () => {
+    if (state.page >= Math.ceil(state.total / limit)) return state;
+
     state.page++;
 
     return load();
   };
 
   /**
-   * @returns {Promise<{total: number, page: number, items: *[]}>}
+   * @returns {{total: number, page: number, items: *[]}|Promise<{total: number, page: number, items: *[]}>}
    */
   const previous = () => {
+    if (state.page <= 1) return state;
+
     state.page--;
 
     return load();

tools/api/fastApi/adapter.spec.js

@@ -111,47 +111,100 @@ describe('#fastApiTableAdapter', () => {
     });
 
     describe('#next', () => {
-      beforeEach(async () => {
-        fetchResponse.contentRangeTotal = 1;
-        fetchResponse.items = ['foo'];
+      describe('if there is a next page', () => {
+        beforeEach(async () => {
+          fetchResponse.contentRangeTotal = 11;
+          fetchResponse.items = ['foo'];
 
-        result = await adapter.next();
-      });
+          await adapter.load();
+          result = await adapter.next();
+        });
 
-      it('increases the current page and performs a request', () => {
-        expect(fetch).toHaveBeenCalledWith('/foo?limit=10&offset=10');
+        it('increases the current page and performs a request', () => {
+          expect(fetch).toHaveBeenCalledTimes(2);
+          expect(fetch).toHaveBeenCalledWith('/foo?limit=10&offset=10');
+        });
+
+        it('returns the result of calling load', () => {
+          expect(result).toEqual({
+            page: 2,
+            total: 11,
+            items: ['foo'],
+          });
+        });
       });
 
-      it('returns the result of calling load', () => {
-        expect(result).toEqual({
-          page: 2,
-          total: 1,
-          items: ['foo'],
+      describe('if there is NOT a next page', () => {
+        beforeEach(async () => {
+          fetchResponse.contentRangeTotal = 10;
+          fetchResponse.items = ['foo'];
+
+          await adapter.load();
+          result = await adapter.next();
+        });
+
+        it('does not perform a request', () => {
+          expect(fetch).toHaveBeenCalledTimes(1);
+        });
+
+        it('returns the current state', () => {
+          expect(result).toEqual({
+            page: 1,
+            total: 10,
+            items: ['foo'],
+          });
         });
       });
     });
 
     describe('#previous', () => {
-      beforeEach(async () => {
-        fetchResponse.contentRangeTotal = 1;
-        fetchResponse.items = ['bar'];
+      describe('if there is a previous page', () => {
+        beforeEach(async () => {
+          fetchResponse.contentRangeTotal = 33;
+          fetchResponse.items = ['bar'];
 
-        // Increase page to 3
-        await adapter.next();
-        await adapter.next();
+          // Increase page to 3
+          await adapter.load();
+          await adapter.next();
+          await adapter.next();
 
-        result = await adapter.previous();
-      });
+          result = await adapter.previous();
+        });
 
-      it('decreases the current page and performs a request', () => {
-        expect(fetch).toHaveBeenCalledWith('/foo?limit=10&offset=20');
+        it('decreases the current page and performs a request', () => {
+          expect(fetch).toHaveBeenCalledWith('/foo?limit=10&offset=20');
+        });
+
+        it('returns the result of calling load', () => {
+          expect(result).toEqual({
+            page: 2,
+            total: 33,
+            items: ['bar'],
+          });
+        });
       });
 
-      it('returns the result of calling load', () => {
-        expect(result).toEqual({
-          page: 2,
-          total: 1,
-          items: ['bar'],
+      describe('if there is NOT a previous page', () => {
+        beforeEach(async () => {
+          fetchResponse.contentRangeTotal = 33;
+          fetchResponse.items = ['bar'];
+
+          // Do not increase page
+          await adapter.load();
+
+          result = await adapter.previous();
+        });
+
+        it('does not performs a request', () => {
+          expect(fetch).toHaveBeenCalledTimes(1);
+        });
+
+        it('returns the current state', () => {
+          expect(result).toEqual({
+            page: 1,
+            total: 33,
+            items: ['bar'],
+          });
         });
       });
     });