LITE-21519 Added support to Django 4.0 and bumped deps and workflows #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxipavlovic
force-pushed
the
feature/LITE-21519
branch
from
ff14a13 to
1262c8e
Compare
marcserrat
approved these changes
Dec 17, 2021
ghost
approved these changes
Dec 17, 2021
| with: | ||
| time: '60s' | ||
| time: '120s' | ||
| - name: SonarQube Quality Gate check |
There was a problem hiding this comment.
Probably instead of waiting 120s better to follow the strategy, we adopt for connect-cli.
It means a job just for Sonar that depends on previous builds. It seems that quality check fails only when repeated many times due to a test matrix.
Please take a look https://github.com/cloudblue/connect-cli/blob/a02728c5c991ecf76768da6331bcfe76d6c863c4/.github/workflows/build.yml#L37
Member
Author
There was a problem hiding this comment.
I will leave it up to you :)))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.