LaravelException not being parsed

[ijmorales]

Hello. I'm on the task of developing an API and decided to implement this package. I'm getting an error that I wasn't able to figure out.

Problem description

Problem at parsing Laravel Exception. App container throws BindingResolutionException when instantiating LaravelJsonApi\Exceptions\ExceptionParser.

Further explanation and examples

I have created several resources and I'm getting 500 error coded responses when the Exception being thrown belongs to Laravel instead of LaravelJsonApi.
For instance, querying http://localhost:8000/api/v1/clients/2000 returns a response like the following, as expected because a client with such id doesn't exist in the database.

GET /api/v1/clients/2000? HTTP/1.1
{
    "errors": [
        {
            "status": "404",
            "title": "Not Found",
            "detail": "Resource clients with id 2000 does not exist."
        }
    ]
}

So, the exception handler that comes with this package seems to be working fine when dealing with LaravelJsonApi exceptions. The problem I'm encountering is when handling Laravel Exceptions. For example, the POST request below do create a new client when the company referenced exists. If the company id submitted is invalid, a PDOException (Integrity constraint violation) is thrown.

POST /api/v1/clients/ HTTP/1.1
Host: localhost:8000
Accept: application/vnd.api+json
Content-Type: application/vnd.api+json
{
	"data": {
		"type": "clients",
		"attributes": {
			"name": "Nacho",
			"company_id": 8,
		}
	}
}

I'm expecting the Exception to be parsed, but the Container fails trying to instantiate the ExceptionParser, throwing the following exception in Container at method notInstantiable():
Illuminate\Contracts\Container\BindingResolutionException: Target [CloudCreativity\LaravelJsonApi\Contracts\Exceptions\ErrorIdAllocatorInterface] is not instantiable while building [CloudCreativity\LaravelJsonApi\Exceptions\ExceptionParser]. And therefore returning a 500 status code.

Notes

• Although this is my first time implementing this package, the setup was done according to the docs. All my resources routes have the following middlewares (from php artisan route:list): api, auth:api, json-api:default, json-api.content.
• Authentication is being handled by Laravel Passport OAuth 2.0.
• Maybe related to Auth middleware raising unresolvable dependency on Api class #284

[lindyhopchris]

Hi! I'll take a look into this. However, I'm not sure why you're getting the binding resolution failure, as the constructor for the exception parser has the error id allocator as nullable - so the Laravel container shouldn't be looking up the binding for the error id allocator if there isn't one bound in the container.

Can you confirm the exact Laravel version you are on, and the exact Laravel JSON API version?

As a side note, your post data goes against the JSON API spec's recommendation:

Although has-one foreign keys (e.g. author_id) are often stored internally alongside other information to be represented in a resource object, these keys SHOULD NOT appear as attributes.

So your request should actually be:

POST /api/v1/clients/ HTTP/1.1
Host: localhost:8000
Accept: application/vnd.api+json
Content-Type: application/vnd.api+json
{
	"data": {
		"type": "clients",
		"attributes": {
			"name": "Nacho"
		},
		"relationships": {
			"company": {
                            "data": { "type": "companies", "id": "8" }
                        }
		}
	}
}

[ijmorales]

Hi, thanks for your answer. I'm on:

laravel/framework v5.7.26
cloudcreativity/laravel-json-api v1.0.0-rc.2

Thanks for you sidenote, I'll take care of the request format. Let me know if you need more information.

[lindyhopchris]

@ijmorales did you ever figure this one out?

If you're still encountering it, could you try on the 1.1.0 version of this package, that I've just tagged?

[baltun]

I have the same issue in 1.1.0 version
Handling database exception "No query results for model" in app/Exceptions/Handler.php

public function render($request, Exception $exception)
{
    if($request->wantsJson()){
        return $this->renderJsonApi($request, $exception);
    }
}

it returns error 500

[lindyhopchris]

@baltun looks unrelated as you're getting a different exception. A database exception should be returned as a 500 as it is an internal server error.

Side note: I'm assuming you're using $request->wantsJson() intentionally instead of the $this->isJsonApi($request, $exception) as per the installation docs.

[lindyhopchris]

@baltun unless you also mean you're also getting the same binding resolution exception about the ErrorIdAllocatorInterface?

FYI I still have no idea why that is caused as I've been unable to reproduce the error.

[lindyhopchris]

Anyone encountering this, please could you try this:

$ php artisan tinker
Psy Shell v0.9.9 (PHP 7.3.6 — cli) by Justin Hileman
>>> $p = app(\CloudCreativity\LaravelJsonApi\Contracts\Exceptions\ExceptionParserInterface::class);
=> CloudCreativity\LaravelJsonApi\Exceptions\ExceptionParser {#3311}
>>> 

and then if an exception is thrown then provide the stack trace using the tinker wtf command.

[lindyhopchris]

Closing this due to inactivity, and because I haven't been able to reproduce it. If anyone else encounters this issue, please open a new issue.