-
Notifications
You must be signed in to change notification settings - Fork 2
[CYB-135] Bash script update #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… in global kafka.properties * Update cs-restart scripts do not reference global kafka.properties.
* Removed unused files. * Refactoring bash scripts as method in env.sh.
* Refactored a scripts permissions. * Refactored a scripts alias. * Refactored and removed scripts that are no longer in use.
carolynduby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Vlad -
looks good but I'm not sure about the upsert rule script. Where is the run_java_class command defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is the run_java_class script defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this script needs to stay. This is adding a new enrichment loading config file.
* Revert removing cs-add-enrich file.
* Update meta files.
# Conflicts: # flink-cyber/cyber-parcel/src/main/meta/permissions.json
carolynduby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
No description provided.