[CYB-150] Sample Folder as Live View input #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas-panasiuk
added
checked on a cluster
carolynduby
added
the
next release
...ent/src/app/chain-page/components/live-view/live-view-result/live-view-result.component.html
Outdated
Show resolved
Hide resolved
.../sample-data-form/sample-data-text-folder-input/sample-data-text-folder-input.component.html
Outdated
Show resolved
Hide resolved
.../sample-data-form/sample-data-text-folder-input/sample-data-text-folder-input.component.html
Outdated
Show resolved
Hide resolved
.../sample-data-form/sample-data-text-folder-input/sample-data-text-folder-input.component.html
Outdated
Show resolved
Hide resolved
|
|
||
| ngOnInit(): void { | ||
| this.store.dispatch(SampleFolderViewInitializedAction()); | ||
| this.sampleFolderPath$.subscribe(value => { |
Collaborator
There was a problem hiding this comment.
this call would probably be better moved to the constructor, since it initializes the folderForm field.
Collaborator
Author
There was a problem hiding this comment.
it won't work in that case, we need for the page to initialize before
...ew/sample-data-form/sample-data-text-folder-input/sample-data-text-folder-input.component.ts
Outdated
Show resolved
Hide resolved
...onents/live-view/sample-data-form/sample-data-text-input/sample-data-text-input.component.ts
Show resolved
Hide resolved
.../src/main/java/com/cloudera/parserchains/queryservice/controller/ParserSampleController.java
Show resolved
Hide resolved
.../src/main/java/com/cloudera/parserchains/queryservice/controller/ParserSampleController.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/cloudera/parserchains/queryservice/controller/ParserSampleController.java
Outdated
Show resolved
Hide resolved
vpavlenko-cv
approved these changes
Jun 28, 2023
# Conflicts: # flink-cyber/metron-parser-chain/parser-chains-config-service/src/main/java/com/cloudera/parserchains/queryservice/config/AppProperties.java # flink-cyber/metron-parser-chain/parser-chains-config-service/src/main/java/com/cloudera/parserchains/queryservice/controller/ChainController.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.