[CYB-170] Added TableApi indexer table mapping validation #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas-panasiuk
added
checked on a cluster
carolynduby
requested changes
Aug 7, 2023
Collaborator
carolynduby
left a comment
carolynduby
left a comment
There was a problem hiding this comment.
Changes look good. I think the validateMappings method could have a unit test.
Thanks!
...dexing-hive/src/main/java/com/cloudera/cyber/indexing/hive/tableapi/TableApiAbstractJob.java
Outdated
Show resolved
Hide resolved
…the existing table as well as table config
…st for validation
carolynduby
force-pushed
the
CYB-170
branch
from
d554036 to
5e50b7e
Compare
carolynduby
approved these changes
Sep 15, 2023
Collaborator
carolynduby
left a comment
carolynduby
left a comment
There was a problem hiding this comment.
Looks good. Added test cases to jira.
mikepresseau
pushed a commit
that referenced
this pull request
Nov 14, 2025
RELENG-17730: Add multi-platform build config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.