Skip to content

Conversation

@dmilov
Copy link
Contributor

@dmilov dmilov commented Sep 8, 2021

Signed-off-by: Dimitar Milov dmilov@vmware.com

Description

Add Project URI in the Module Manifest to make it available on the PSGallery Module web page

Closes: #45

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.

  • Local run all unit and integration tests
> .\build.ps1
[9:59:40 AM] INFO: Publish CloudEvents.Sdk Module to 'C:\git-repos\github\sdk-powershell\CloudEvents.Sdk'
[9:59:42 AM] INFO: Run unit tests

Starting discovery in 9 files.
Discovery finished in 579ms.
[+] C:\git-repos\github\sdk-powershell\test\unit\ConvertFrom-HttpMessage.Tests.ps1 1.33s (511ms|626ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\ConvertTo-HttpMessage.Tests.ps1 456ms (173ms|224ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\New-CloudEvent.Tests.ps1 240ms (48ms|149ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\Read-CloudEventData.Tests.ps1 240ms (30ms|149ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\Read-CloudEventJsonData.Tests.ps1 267ms (75ms|154ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\Read-CloudEventXmlData.Tests.ps1 291ms (101ms|147ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\Set-CloudEventData.Tests.ps1 380ms (115ms|221ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\Set-CloudEventJsonData.Tests.ps1 231ms (45ms|151ms)
[+] C:\git-repos\github\sdk-powershell\test\unit\Set-CloudEventXmlData.Tests.ps1 297ms (97ms|164ms)
Tests completed in 3.78s
Tests Passed: 32, Failed: 0, Skipped: 0 NotRun: 0
[9:59:48 AM] INFO: Run integration tests

Starting discovery in 1 files.
Discovery finished in 211ms.
Tests completed in 4.9s
Tests Passed: 5, Failed: 0, Skipped: 0 NotRun: 0

Test Configuration:

  • Toolchain:
  • SDK:
  • (add more if needed)

Checklist:

  • My code follows the contribution
    guidelines
    of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: Dimitar Milov <dmilov@vmware.com>
Copy link
Member

@embano1 embano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmilov dmilov merged commit 23e8b67 into cloudevents:main Sep 8, 2021
@dmilov dmilov deleted the topic/add-project-uri branch September 8, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add project info to module

2 participants