Strip leading slash from OCSP request if present#770
Merged
lziest merged 1 commit intocloudflare:masterfrom May 19, 2017
Merged
Strip leading slash from OCSP request if present#770lziest merged 1 commit intocloudflare:masterfrom
lziest merged 1 commit intocloudflare:masterfrom
Conversation
rolandshoemaker
force-pushed
the
ocsp-string-leading
branch
from
ecad56f to
11bb839
Compare
Codecov Report
@@ Coverage Diff @@
## master #770 +/- ##
==========================================
+ Coverage 57.67% 57.75% +0.08%
==========================================
Files 78 78
Lines 6922 6924 +2
==========================================
+ Hits 3992 3999 +7
+ Misses 2513 2509 -4
+ Partials 417 416 -1
Continue to review full report at Codecov.
|
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes certain issues we've seen in the wild. Based on the ASN.1 structure of OCSP requests we should never see a valid request that starts with a slash.