[workers] Update QR Code example #17230
Conversation
kristianfreeman
requested review from
a team,
GregBrimble,
WalshyDev,
irvinebroque and
mikenomitch
as code owners
![hyperlint-ai[bot]](https://avatars.githubusercontent.com/in/718456?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 files reviewed, 1 total issue(s) found.
Note: We resolved prior Hyperlint review comments because:
We updated our inline suggestion AI.
We do this to avoid keeping outdated or irrelevant comments around. We'll leave a new review with current comments below.
src/content/docs/workers/tutorials/build-a-qr-code-generator/index.mdx
Outdated
Show resolved
Hide resolved
Deploying cloudflare-docs with
|
| Latest commit: |
fedb77f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://773fae28.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://qrcode-tut-update.cloudflare-docs-7ou.pages.dev |
|
Files with changes (up to 15) |
src/content/docs/workers/tutorials/build-a-qr-code-generator/index.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers/tutorials/build-a-qr-code-generator/index.mdx
Outdated
Show resolved
Hide resolved
|
Hi @kristianfreeman — I approved this PR and left a couple of suggestions. Otherwise, it looks like you can skip the suggestion from hyperlint about the quotes. And then, it also seems there's a merge conflict. I'd resolve it myself, but I'm not sure if that conflicting content is relevant to keep. Let me know if you are good to wrap those last things up and merge or if there's anything I can do to help. Thank you! |
There was a problem hiding this comment.
1 files reviewed, 1 total issue(s) found.
Note: We resolved prior Hyperlint review comments because:
We noticed a change to the style guide files.
We do this to avoid keeping outdated or irrelevant comments around. We'll leave a new review with current comments below.
Updates QR Code example to use a pure JS library for generating QR codes. Closes #14797
…ndex.mdx Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
kristianfreeman
force-pushed
the
qrcode-tut-update
branch
from
0059958 to
fedb77f
Compare
|
Hi @crwaters16 - Just an FYI that I resolved a comment in this PR that was made to @bllchmbrs about including exceptions for backticks in Hyperlint. It didn't seem like a blocker so we went ahead and merged. |
* [workers] Update QR Code example Updates QR Code example to use a pure JS library for generating QR codes. Closes #14797 * Update src/content/docs/workers/tutorials/build-a-qr-code-generator/index.mdx Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com> * Update with suggestions --------- Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
7 participants
Updates QR Code example to use a pure JS library for generating QR codes.
Closes #14797
I've also updated my repo with the source code to match the tutorial.