Update wrangler workers site to recommend workers static assets #18119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following recommends Cloudflare Pages over Workers Sites, which is inconsistent with other documentation that recommends Workers Static Assets https://developers.cloudflare.com/workers/wrangler/configuration/#workers-sites
nickbabcock
requested review from
a team,
GregBrimble,
dario-piotrowicz,
irvinebroque,
penalosa and
petebacondarwin
as code owners
github-actions
bot
assigned
dario-piotrowicz,
GregBrimble,
irvinebroque,
penalosa and
petebacondarwin
dario-piotrowicz
approved these changes
Nov 12, 2024
Member
dario-piotrowicz
left a comment
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Looks good to me! thanks a bunch for the update @nickbabcock 🙂
ToriLindsay
approved these changes
Dec 2, 2024
workers-devprod
added
the
contribution
|
Congratulations @nickbabcock, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm46uxq2h00320cmkifvawtw4 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
harshil1712
pushed a commit
that referenced
this pull request
Dec 3, 2024
* Update wrangler workers site to recommend workers static assets The following recommends Cloudflare Pages over Workers Sites, which is inconsistent with other documentation that recommends Workers Static Assets https://developers.cloudflare.com/workers/wrangler/configuration/#workers-sites * Update src/content/docs/workers/wrangler/configuration.mdx --------- Co-authored-by: ToriLindsay <tgalatro@cloudflare.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The following recommends Cloudflare Pages over Workers Sites, which is inconsistent with other documentation that recommends Workers Static Assets
https://developers.cloudflare.com/workers/wrangler/configuration/#workers-sites
Screenshots (optional)
Now the section looks like: