Skip to content

Conversation

@esheacf
Copy link
Contributor

@esheacf esheacf commented Feb 14, 2025

Summary

Changed China Express to Global Acceleration as part of rebrand.
Renamed china-express.mdx to global-acceleration.mdx

Screenshots (optional)

Documentation checklist

@esheacf esheacf requested review from a team and pedrosousa as code owners February 14, 2025 01:44
Removed unnecessary volta version.
@github-actions
Copy link
Contributor

This PR changes current filenames or deletes current files. Make sure you have redirects set up to cover the following paths:

  • /china-network/concepts/china-express/

@pedrosousa
Copy link
Contributor

Hi @esheacf
We already have an ongoing PR for the same change: #19228. Are these changes the same? Should we merge the changes proposed in the two PRs?
Also, we still need a redirect from the old page URL to the new one.

@esheacf
Copy link
Contributor Author

esheacf commented Feb 14, 2025

Hi @pedrosousa,
This is my first time creating a PR, so I'm not sure what the general procedure is. I tried to follow some Wikis I happen to find that outlines how to add content to the dev docs. Apologies for the mistakes I made. It would be best to merge both of these changes proposed in the PR. The latest changes in 19986 would be the most accurate. If you could provide me instruction/Wiki on how to redirect the old page to the new one, I'd be happy to do so. Any other guidance would be greatly appreciated as well!

Thanks,
Erin

@pedrosousa
Copy link
Contributor

Hi @pedrosousa, This is my first time creating a PR, so I'm not sure what the general procedure is. I tried to follow some Wikis I happen to find that outlines how to add content to the dev docs. Apologies for the mistakes I made. It would be best to merge both of these changes proposed in the PR. The latest changes in 19986 would be the most accurate. If you could provide me instruction/Wiki on how to redirect the old page to the new one, I'd be happy to do so. Any other guidance would be greatly appreciated as well!

Thanks, Erin

Should we close the other PR, then, or do we still need to bring some of the changes to this PR?

Regarding the redirect, I already added it in a separate commit: 6974245 (line 240)

You basically have to follow the instructions we have in Dev Docs for Pages redirects:
https://developers.cloudflare.com/pages/configuration/redirects/

I also fixed a link and did another feature rename in the China Network docs home page: fd995cd

@esheacf
Copy link
Contributor Author

esheacf commented Feb 25, 2025

Hi Pedro,
Thank you so much for helping me add the redirect. And apologies for the later reply, I just returned from PTO today. We can close the other PR and use this current PR with your commits. Thank you again, and I'll be sure to take notes from your commits as well.

@esheacf
Copy link
Contributor Author

esheacf commented Feb 26, 2025

@pedrosousa Is there anything else I can do on my end before this change is merged to production? Hoping to get these changes out before the end of this month as part of our rebranding initiative.

@pedrosousa pedrosousa merged commit 8ba11a2 into production Mar 6, 2025
11 checks passed
@pedrosousa pedrosousa deleted the erin/china-network-update branch March 6, 2025 11:01
@pedrosousa
Copy link
Contributor

Sorry for the delay, @esheacf (some PTO got in the way).

@esheacf
Copy link
Contributor Author

esheacf commented Mar 6, 2025

Hope you had a wonderful PTO. Thank you again for all your help. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants