[Magic Firewall] Update the bucket name in the packet capture doc #20104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Howdy and thanks for contributing to our repo. We review new, external PRs within 2 weeks. If it's been longer than then without any movement, tag the PR Assignees in a comment. |
Maddy-Cloudflare
approved these changes
Feb 28, 2025
| "colo": "ORD", | ||
| "destination_conf": "gs://test-magic-pcaps" | ||
| "destination_conf": "gs://<bucket-name>" //NOTE: Please ensure you create | ||
| //your own bucket, have it registered in Cloudflare dash and use that. |
Contributor
There was a problem hiding this comment.
Suggested change
| //your own bucket, have it registered in Cloudflare dash and use that. |
| "byte_limit": 100000000, | ||
| "colo": "ORD", | ||
| "destination_conf": "gs://test-magic-pcaps" | ||
| "destination_conf": "gs://<bucket-name>" //NOTE: Please ensure you create |
Contributor
There was a problem hiding this comment.
Suggested change
| "destination_conf": "gs://<bucket-name>" //NOTE: Please ensure you create | |
| "destination_conf": "gs://<bucket-name>" // Ensure you use a bucket that you created and registered in the Cloudflare dashboard |
| "validated": "", | ||
| "destination_conf": "gs://bucket-test", | ||
| "destination_conf": "gs://bucket-test", //NOTE: Please ensure you create | ||
| //your own bucket, have it registered in Cloudflare dash and use that. |
Contributor
There was a problem hiding this comment.
Suggested change
| //your own bucket, have it registered in Cloudflare dash and use that. |
| "submitted": "2022-04-22T18:54:13.397413Z", | ||
| "validated": "", | ||
| "destination_conf": "gs://bucket-test", | ||
| "destination_conf": "gs://bucket-test", //NOTE: Please ensure you create |
Contributor
There was a problem hiding this comment.
Suggested change
| "destination_conf": "gs://bucket-test", //NOTE: Please ensure you create | |
| "destination_conf": "gs://bucket-test", // Ensure you use a bucket that you created and registered in the Cloudflare dashboard |
| "validated": "2022-04-27T14:54:46.440548Z", | ||
| "destination_conf": "gs://bucket-test", | ||
| "destination_conf": "gs://<bucket-name>", //NOTE: Please ensure you create | ||
| //your own bucket, have it registered in Cloudflare dash and use that. |
Contributor
There was a problem hiding this comment.
Suggested change
| //your own bucket, have it registered in Cloudflare dash and use that. |
| "submitted": "2022-04-22T18:54:13.397413Z", | ||
| "validated": "2022-04-27T14:54:46.440548Z", | ||
| "destination_conf": "gs://bucket-test", | ||
| "destination_conf": "gs://<bucket-name>", //NOTE: Please ensure you create |
Contributor
There was a problem hiding this comment.
Suggested change
| "destination_conf": "gs://<bucket-name>", //NOTE: Please ensure you create | |
| "destination_conf": "gs://<bucket-name>", // Ensure you use a bucket that you created and registered in the Cloudflare dashboard |
Contributor
|
Hey @Maddy-Cloudflare - This commit looks good to me. It's always good to have clarifying comments in code snippets in the Developer Docs. Thanks for submitting this change @mbancfmv |
mbancfmv
force-pushed
the
magin/magic-pcap-bucket-name
branch
from
a743c68 to
d7eef7c
Compare
Maddy-Cloudflare
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Magic PCAPs - This PR is to clarify the customer that the specified bucket names in the devdocs are placeholder names and they need to create (and use) their own.
Screenshots (optional)
Documentation checklist