-
Notifications
You must be signed in to change notification settings - Fork 10.3k
builds name mismatch changelog #20122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builds name mismatch changelog #20122
Conversation
|
Howdy and thanks for contributing to our repo. We review new, external PRs within 2 weeks. If it's been longer than then without any movement, tag the PR Assignees in a comment. |
src/content/changelog/workers/2025-02-20-builds-name-conflict.mdx
Outdated
Show resolved
Hide resolved
cmsparks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Co-authored-by: Christian Sparks <csparks1919@hotmail.com>
irvinebroque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like release note not necessarily top-level customer-facing changelog?
src/content/changelog/workers/2025-02-20-builds-name-conflict.mdx
Outdated
Show resolved
Hide resolved
src/content/changelog/workers/2025-02-20-builds-name-conflict.mdx
Outdated
Show resolved
Hide resolved
src/content/changelog/workers/2025-02-20-builds-name-conflict.mdx
Outdated
Show resolved
Hide resolved
src/content/changelog/workers/2025-02-20-builds-name-conflict.mdx
Outdated
Show resolved
Hide resolved
src/content/changelog/workers/2025-02-20-builds-name-conflict.mdx
Outdated
Show resolved
Hide resolved
src/content/changelog/workers/2025-02-20-builds-name-conflict.mdx
Outdated
Show resolved
Hide resolved
I'd argue it might be changelog worthy given we are introducing a new pattern for creating PRs to sync settings for git repos |
irvinebroque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think would benefit from 1, 2, 3 step by step, ex: structure like this
<high level paragraph what we're introducing, big picture, not specific to name mismatch>
Here's how it works:
- Before running your build, Cloudflare checks your Worker's Wrangler configuration file (
wrangler.tomlorwrangler.jsonc) for common errors - If Cloudflare finds an error it can fix, it will submit a pull request to your repository that fixes it.
- Once you merge this pull request, Cloudflare will run your build
We're starting with mismatches in name, etc. (then explain what name thing does and solves). Then — we want feedback on more, etc.
src/content/changelog/workers/2025-02-20-builds-name-conflict.mdx
Outdated
Show resolved
Hide resolved
src/content/changelog/workers/2025-02-20-builds-name-conflict.mdx
Outdated
Show resolved
Hide resolved
src/content/changelog/workers/2025-02-20-builds-name-conflict.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 files reviewed, 1 total issue(s) found.
|
Congratulations @aninibread, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm7jesmiw37300cjszr7fzf8b This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Summary
Screenshots (optional)
Documentation checklist