Skip to content

Conversation

@aninibread
Copy link
Contributor

Summary

Screenshots (optional)

Screenshot 2025-02-19 at 9 39 48 PM

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@github-actions
Copy link
Contributor

Howdy and thanks for contributing to our repo. We review new, external PRs within 2 weeks. If it's been longer than then without any movement, tag the PR Assignees in a comment.

Copy link
Contributor

@cmsparks cmsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Co-authored-by: Christian Sparks <csparks1919@hotmail.com>
Copy link
Contributor

@irvinebroque irvinebroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like release note not necessarily top-level customer-facing changelog?

@jonesphillip

@aninibread
Copy link
Contributor Author

aninibread commented Feb 21, 2025

This seems like release note not necessarily top-level customer-facing changelog?

@jonesphillip

I'd argue it might be changelog worthy given we are introducing a new pattern for creating PRs to sync settings for git repos

Copy link
Contributor

@irvinebroque irvinebroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think would benefit from 1, 2, 3 step by step, ex: structure like this

<high level paragraph what we're introducing, big picture, not specific to name mismatch>

Here's how it works:

  1. Before running your build, Cloudflare checks your Worker's Wrangler configuration file (wrangler.toml or wrangler.jsonc) for common errors
  2. If Cloudflare finds an error it can fix, it will submit a pull request to your repository that fixes it.
  3. Once you merge this pull request, Cloudflare will run your build

We're starting with mismatches in name, etc. (then explain what name thing does and solves). Then — we want feedback on more, etc.

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 files reviewed, 1 total issue(s) found.

@kodster28 kodster28 merged commit af18a05 into cloudflare:production Feb 24, 2025
6 checks passed
@aninibread aninibread deleted the anni/changelog-name-conflict branch February 24, 2025 18:29
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Feb 24, 2025
@holopin-bot
Copy link

holopin-bot bot commented Feb 24, 2025

Congratulations @aninibread, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm7jesmiw37300cjszr7fzf8b

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution [Holopin] Recognizes a docs contribution, big or small size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants