Skip to content

Conversation

@nisbet-hubbard
Copy link
Contributor

Summary

Created entry and linked to instructions.

Screenshots (optional)

Documentation checklist

@github-actions
Copy link
Contributor

Howdy and thanks for contributing to our repo. We review new, external PRs within 2 weeks. If it's been longer than then without any movement, tag the PR Assignees in a comment.

@bwesterb
Copy link
Member

LGTM. As you mention BoringSSL, please add instructions for that too (or leave it out.)

@nisbet-hubbard
Copy link
Contributor Author

Thanks. I’ve taken your advice and removed the BoringSS part since it doesn’t support all the features of nginx.

@RebeccaTamachiro RebeccaTamachiro enabled auto-merge (squash) March 3, 2025 16:50
@RebeccaTamachiro RebeccaTamachiro merged commit 32f03b4 into cloudflare:production Mar 3, 2025
5 of 6 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Mar 3, 2025
@holopin-bot
Copy link

holopin-bot bot commented Mar 3, 2025

Congratulations @nisbet-hubbard, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm7tavvoc03840cl2af6pqhkx

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@RebeccaTamachiro
Copy link
Contributor

@bllchmbrs Hi! I noticed the Link check fails when we receive contributions to the pqc-support page, but then when I test them, the links seem to work just fine

@bllchmbrs
Copy link
Contributor

bllchmbrs commented Mar 12, 2025

@RebeccaTamachiro 2 things:

  1. You can see it's coming from crates - I bet they block crawlers (and that's why it works fine for you).
  2. I will update things on my end so it doesn't scan the entire page for links - just what you added. That should help cut down on the noise too.

edit: now a third thing, I fixed this so that it will only scan links in your change. That should help a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution [Holopin] Recognizes a docs contribution, big or small product:ssl Related to SSL size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants