Workers CORS Proxy example tweaks #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-dont deref the request object multiple times -whitespace in header value is optional per https://tools.ietf.org/html/rfc7230#section-7, remove it to save wire bytes
"Access-Control-Allow-Headers": "Content-Type" is pointless, it is one of 4 whitelisted headers at https://fetch.spec.whatwg.org/#no-cors-safelisted-request-header-name that a client may include as request headers without a preflight, the browser will not do a preflight if only those 4 headers will be explicitly set from XHR with the GET/POST request later
ispivey
approved these changes
Oct 8, 2020
Contributor
|
@ispivey Thanks for the review! |
Deploying with
|
| Latest commit: |
2733c9b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c61ce0ca.cloudflare-docs-7ou.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revised branch from
cloudflare/cloudflare-docs-engine#272
I added spread operator from #272.