Skip to content

Conversation

@kodster28
Copy link
Collaborator

Followed instructions in https://discourse.gohugo.io/t/littlefoot-for-fancy-popup-footnotes/23991 to make footnotes more readable + easier to access in context.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 25, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a48ff17
Status: ✅  Deploy successful!
Preview URL: https://07995014.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://docsite-tooltip.cloudflare-docs-7ou.pages.dev

View logs

@kodster28
Copy link
Collaborator Author

Open question... suggestion to download and host locally in the thread suggesting it.

What exactly does that mean?

@KianNH
Copy link
Member

KianNH commented Jul 27, 2022

Open question... suggestion to download and host locally in the thread suggesting it.

What exactly does that mean?

I think they mean that https://unpkg.com is sometimes a bottleneck - so the rest of your site has loaded but you're waiting on the library to download from their CDN, causing layout shift ( or whatever it does ).

It's jsDelivr as an alternative.

@kodster28
Copy link
Collaborator Author

Thanks for the context, @KianNH!

From looking at Lighthouse testing comparisons, it seems like there isn't any bottleneck. Once this goes live though, I'll keep an eye out and be ready to test other solutions as needed.

@kodster28 kodster28 marked this pull request as ready for review July 28, 2022 14:36
@kodster28 kodster28 merged commit dc69aad into production Jul 28, 2022
@kodster28 kodster28 deleted the docsite-tooltip branch July 28, 2022 15:21
@kodster28
Copy link
Collaborator Author

Just closing the loop here, @KianNH, had to adjust the script slightly in #5338 , but it looks like it's good now

@KianNH
Copy link
Member

KianNH commented Jul 28, 2022

The joys of webperf 🫠

When are we getting Early Hints too? :^)

@kodster28
Copy link
Collaborator Author

Oooh, good suggestion. Getting the Pages team to flip the switch for us (they're working on integrating them into Pages by default).

@KianNH
Copy link
Member

KianNH commented Jul 28, 2022

I’m excited for it! I released a Worker to add them with HTMLRewriter and Obinna made a Pages plug-in from it - now we just need @WalshyDev to make it native ;)

@WalshyDev
Copy link
Member

Enabled for docs and coming soon to a Pages site near you :^)

@KianNH
Copy link
Member

KianNH commented Jul 28, 2022

What's the go-to for handling files with hashes in their name?

i.e the docs site has no link headers right now so there'll be no 103 responses but the JS uses a hash in the filename for cache busting

Can you add those to the _headers file post-build command and Pages will be fine with that? Guess we'd also want the littlefoot package in there too

@WalshyDev
Copy link
Member

WalshyDev commented Jul 28, 2022

Can you add those to the _headers file post-build command and Pages will be fine with that?

Yep. As long as they're there when we read the file (at publish step) it's all cool

@KianNH
Copy link
Member

KianNH commented Jul 28, 2022

Maybe I'll PR something that isn't R2 or Workers for once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants