Skip to content

Commit c272f6a

Browse files
fix: combobox caret lint + remove stale eslint-disable comments (#228)
1 parent 5e12c15 commit c272f6a

File tree

4 files changed

+12
-7
lines changed

4 files changed

+12
-7
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@cloudflare/kumo": patch
3+
---
4+
5+
Fix combobox caret icon to use text-kumo-subtle with fill-current instead of invalid fill-kumo-subtle token

packages/kumo/src/code/provider.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ export function ShikiProvider({
111111

112112
const highlighter = await createHighlighterCore({
113113
themes: [githubLight.default, vesper.default],
114-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
114+
115115
langs: langModules.map((m) => m.default) as any,
116116
engine: engineInstance,
117117
});

packages/kumo/src/code/server.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ export async function highlightCode(
108108

109109
const highlighter = await createHighlighterCore({
110110
themes: [githubLight.default, vesper.default],
111-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
111+
112112
langs: [langModule.default] as any,
113113
engine: engineInstance,
114114
});
@@ -178,7 +178,7 @@ export async function createServerHighlighter(
178178

179179
const highlighter: HighlighterCore = await createHighlighterCore({
180180
themes: [githubLight.default, vesper.default],
181-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
181+
182182
langs: langModules.map((m) => m.default) as any,
183183
engine: engineInstance,
184184
});

packages/kumo/src/components/combobox/combobox.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -252,13 +252,13 @@ function TriggerValue({
252252
<ComboboxBase.Value>{props.children}</ComboboxBase.Value>
253253
<ComboboxBase.Icon
254254
className={cn(
255-
"absolute top-1/2 -translate-y-1/2 flex items-center",
255+
"absolute top-1/2 -translate-y-1/2 flex items-center text-kumo-subtle",
256256
iconStyles.iconRight,
257257
)}
258258
>
259259
<CaretDownIcon
260260
size={iconStyles.iconSize}
261-
className="fill-kumo-subtle"
261+
className="fill-current"
262262
/>
263263
</ComboboxBase.Icon>
264264
</ComboboxBase.Trigger>
@@ -321,13 +321,13 @@ function TriggerInput(props: ComboboxBase.Input.Props) {
321321
<ComboboxBase.Trigger className="p-0">
322322
<ComboboxBase.Icon
323323
className={cn(
324-
"absolute top-1/2 flex -translate-y-1/2 cursor-pointer",
324+
"absolute top-1/2 flex -translate-y-1/2 cursor-pointer text-kumo-subtle",
325325
iconStyles.caretRight,
326326
)}
327327
>
328328
<CaretDownIcon
329329
size={iconStyles.iconSize}
330-
className="fill-kumo-subtle"
330+
className="fill-current"
331331
/>
332332
</ComboboxBase.Icon>
333333
</ComboboxBase.Trigger>

0 commit comments

Comments
 (0)