bug: RtkClock does not accept `size` prop

[jesusalber1]

Hello,

I get a type error when I use the size attribute with the RtkClock component: ‎<RtkClock size="sm" />. The style is properly applied, so it seems it's just a type issue.

Here is the detailed error message:

Type error: Type '{ size: string; }' is not assignable to type 'IntrinsicAttributes & RtkClock & Omit<HTMLAttributes<HTMLRtkClockElement>, "style"> & StyleReactProps & RefAttributes<...>'.

  Property 'size' does not exist on type 'IntrinsicAttributes & RtkClock & Omit<HTMLAttributes<HTMLRtkClockElement>, "style"> & StyleReactProps & RefAttributes<...>'.
  64 |       <header className='flex items-center justify-end gap-2'>
  65 |         <RtkParticipantCount size='sm' />
> 66 |         <RtkClock size='sm' />
     |                   ^
  67 |       </header>

I'll have a PR ready with a fix shortly.

[ravindra-dyte]

Hi @jesusalber1 , thanks for raising the issue and the PR. As of now, RtkClock doesn't need the size param because the component itself has no use for it. Components that use size, have the reference to the prop using this.size however that is not the case with RtkClock.

We have many components that may not need meeting/size/t/iconPack components, therefore such props are omitted. You can simply stop passing size prop to the component in your custom integration to make the error go away.

May i know what do you mean by The style is properly applied? Are you seeing any change in behavior by passing size prop?

[jesusalber1]

Hi @ravindra-dyte, thank you for taking a look! I've replied directly in the PR: #49 (comment)

[github-actions]

🎉 This issue has been resolved in version 1.0.6-staging.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This issue has been resolved in version 1.0.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀