Skip to content

Conversation

@ghostwriternr
Copy link
Member

Summary

Removes multi-arch Docker image publishing to ensure dev/prod parity. Production only supports linux/amd64, and publishing ARM64 images caused Docker to automatically select the ARM variant on ARM hosts, creating architecture mismatches.

Changes

  • Simplified CI workflows to build linux/amd64 only
  • Updated docker:local script to force amd64 platform
  • Removed ARM64 references from all example Dockerfiles
  • Fixed pre-commit hook issue with package.json files

Fixes #39

Production only supports linux/amd64. Publishing ARM64 images caused
Docker to automatically select the ARM variant on ARM hosts, creating
dev/prod architecture mismatch and potential platform-specific bugs.

ARM Mac users will use emulation automatically, ensuring local dev
matches production deployment.
Remove json from biome-fix glob since biome ignores package.json files.
Prettier in the format command already handles JSON formatting.
@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2025

🦋 Changeset detected

Latest commit: a99d488

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/sandbox Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

claude[bot]

This comment was marked as outdated.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 25, 2025

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/sandbox-sdk/@cloudflare/sandbox@245

commit: a99d488

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

🐳 Docker Image Published

FROM cloudflare/sandbox:0.0.0-pr-245-fd71372

Version: 0.0.0-pr-245-fd71372

You can use this Docker image with the preview package from this PR.

@ghostwriternr
Copy link
Member Author

Docs updates: cloudflare/cloudflare-docs#26744

Link to official docs setup guide in prerequisites for Docker installation
and troubleshooting.
agents-git-bot bot pushed a commit to cloudflare/cloudflare-docs that referenced this pull request Nov 25, 2025
Update documentation to reflect that Sandbox SDK now builds Docker
images for linux/amd64 only to ensure dev/prod parity.

Changes:
- Add architecture compatibility section to docker-setup partial
- Clarify that ARM Mac users will use automatic emulation
- Update Dockerfile reference to note linux/amd64 architecture
- Explain dev/prod parity benefits

Related to cloudflare/sandbox-sdk#245

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
claude[bot]

This comment was marked as outdated.

@ghostwriternr ghostwriternr merged commit ecaafa9 into main Nov 26, 2025
15 checks passed
@ghostwriternr ghostwriternr deleted the fix-image-arch branch November 26, 2025 12:46
@github-actions github-actions bot mentioned this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix local dev (on a mac)

2 participants