Skip to content

Conversation

@threepointone
Copy link
Collaborator

(No need for a changeset for this one)

(No need for a changeset for this one)
@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2025

🦋 Changeset detected

Latest commit: 3b35950

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/sandbox Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

Dependency updates look good overall, but there's one issue with the lefthook configuration.

Issue: Astro files removed from linting

The lefthook.yml change removed .astro files from the Biome linting glob pattern. Since Biome 2.3 introduced full support for Astro files (which this PR upgrades to), and there are Astro files in sites/sandbox/src/, they should still be linted.

Removing .json is fine (those files are already excluded in biome.json config).

Recommendation

Restore .astro to the lefthook glob pattern:

glob: '{packages,examples,sites}/**/*.{js,ts,tsx,astro}'

All other dependency updates are appropriate patch/minor version bumps with no breaking changes expected.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 26, 2025

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/sandbox-sdk/@cloudflare/sandbox@251

commit: e72261f

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

🐳 Docker Image Published

FROM cloudflare/sandbox:0.0.0-pr-251-1d37a2e

Version: 0.0.0-pr-251-1d37a2e

You can use this Docker image with the preview package from this PR.

@ghostwriternr ghostwriternr merged commit ba83581 into main Nov 26, 2025
8 checks passed
@ghostwriternr ghostwriternr deleted the update-deps branch November 26, 2025 12:49
@github-actions github-actions bot mentioned this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants