Add support for parsing Signature-Agent as sfv::Dictionary + simplify library #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the following constructs: 1. `WebBotAuthSignedMessage` 2. `SignedMessage::fetch_all_signature_headers` 3. `SignedMessage::fetch_all_signature_inputs` and modifies the `lookup_component` method to be the primary source of information about a message. The goal here is to make it possible to treat all HTTP headers, including special ones like `Signature-Agent`, etc. on the same footing. It also removes a source of complexity for implementors, since they would need to maintain an independent method just to fetch special values.
AkshatM
changed the title
thibmeu
reviewed
Oct 22, 2025
thibmeu
approved these changes
Oct 22, 2025
Collaborator
thibmeu
left a comment
thibmeu
left a comment
There was a problem hiding this comment.
overall looks good. let's ensure we don't publish the crate yet, there will be some changes.
nits on the example file: would be good to have the origin of the key to make sure it's not used in prod
This change supports handling Signature-Agent as either an sfv::Dictionary or an sfv::Item. To decide which way to process, it relies on whether or not the `Signature-Agent` header listed in the `Signature-Input` field has an associated `key` parameter. If present, it attempts to parse as a dictionary. I've added tests to ensure both types can be handled perfectly well.
AkshatM
force-pushed
the
signature_agent_as_sfv_dictionary
branch
from
6277dee to
5dca4c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify interface: concentrate into
lookup_componentmethodThis change removes the following constructs:
WebBotAuthSignedMessageSignedMessage::fetch_all_signature_headersSignedMessage::fetch_all_signature_inputsand modifies the
lookup_componentmethod to be the primary source ofinformation about a message. The goal here is to make it possible to
treat all HTTP headers, including special ones like
Signature-Agent,etc. on the same footing. It also removes a source of complexity for
implementors, since they would need to maintain an independent method
just to fetch special values.
Add support for parsing Signature-Agent as an sfv::Dictionary
This change supports handling Signature-Agent as either an
sfv::Dictionary or an sfv::Item. To decide which way to process, it
relies on whether or not the
Signature-Agentheader listed in theSignature-Inputfield has an associatedkeyparameter. If present,it attempts to parse as a dictionary.
I've added tests to ensure both types can be handled perfectly well.