Add multi-tech support to Dynatrace OneAgent integration #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjun024
requested changes
Nov 14, 2024
Member
arjun024
left a comment
arjun024
left a comment
There was a problem hiding this comment.
Could you please combine this test case with an already existing spec? The buildpack test suite already takes an exorbitant amount of time to run (See https://buildpacks.ci.cf-app.com/teams/main/pipelines/php-buildpack/jobs/specs-edge-integration-develop-cflinuxfs4/builds/146) and we are trying to prune tests. I think tests in deploy_a_php_app_with_dynatrace_test.go could be combined further, but you don't necessarily have to do that right now
…upon request from upstream maintainer
Contributor
Author
|
@arjun024 merged the test for the new feature with another one that already existed. |
arjun024
approved these changes
Nov 18, 2024
arjun024
added a commit
that referenced
this pull request
Dec 13, 2024
You can't run 2 cf cups with the same service name. Modified tests in #1117
arjun024
added a commit
that referenced
this pull request
Dec 13, 2024
You can't run 2 cf cups with the same service name. Modified tests in #1117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
This adds suport for a new, optional, configuration property named "addtechnologies" to Dynatrace deployment scenarios.
An explanation of the use cases your change solves
This is required to configure additional code-modules for the OneAgent in multi-buildpack and sidecars deployments
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have added an integration test