Skip to content

Install bootstrapped Python into php-buildpack specific location #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2023
Merged

Install bootstrapped Python into php-buildpack specific location #864

merged 1 commit into from
Apr 13, 2023

Conversation

@brayanhenao
Copy link
Contributor

@brayanhenao brayanhenao commented Apr 12, 2023

This Buildpack bootstraps Python into /tmp/python, and there are situations where multiple Buildpacks attempt to bootstrap Python into the same location.

Fix #858

@brayanhenao brayanhenao linked an issue Apr 12, 2023 that may be closed by this pull request
Install bootstrapped python into buildpack-specific namespace #858
Closed
@brayanhenao brayanhenao requested a review from robdimsdale April 12, 2023 20:39
robdimsdale
robdimsdale approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@robdimsdale robdimsdale left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out this PR locally and could not see any remaining references to /tmp/python - LGTM 👍

@robdimsdale robdimsdale merged commit 7243589 into develop Apr 13, 2023
@robdimsdale robdimsdale deleted the namespace-bootstrap-python branch April 13, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robdimsdale robdimsdale robdimsdale approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Install bootstrapped python into buildpack-specific namespace

3 participants

@brayanhenao @robdimsdale @cf-gitbot