Skip to content

Conversation

@sandrinr
Copy link

Fix a typo "bin/steps/cryptography" which enables detection of cryptography requirement.

@cfdreddbot
Copy link

Hey sandrinr!

Thanks for submitting this pull request!

All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/78784224.

@squeedee
Copy link
Contributor

Hey Raffaele!

We test regressions around here as much as we can to ensure they don't repeat. Would you mind modifying an existing fixture (https://github.com/cloudfoundry/python-buildpack/tree/master/cf_spec/fixtures/flask_web_app for example) or providing us with one (as simple as possible) that demonstrates the issue and that this change fixes it?

We don't actually maintain most of the buildpack code, opting to depend on Heroku's excellent work in this area. However when a real problem and fix is available, we do all we can to ensure it's pulled in and tested, then we can push it upstream to heroku as well. With a fixture in place, we can then ensure the Heroku code does not regress.

Thanks for your time!

@jchesterpivotal
Copy link
Contributor

Hi @sandrinr -- it looks like someone has beaten us all to the punch and submitted a PR to Heroku to fix this typo. Thanks again for submitting your PR. I'm going to close it now in anticipation of Heroku picking up the fix at their end.

@sandrinr sandrinr deleted the fix-cryptography-typo branch October 9, 2014 18:08
@sandrinr
Copy link
Author

sandrinr commented Oct 9, 2014

Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants