Skip to content

Conversation

@winkingturtle-vmw
Copy link
Contributor

@winkingturtle-vmw winkingturtle-vmw commented Sep 11, 2023

Follow up for #334

bump gorouter
bump multierror
bump route-registrar
bump routing-api
bump routing-api-cli
bump routing-info

Submodule src/code.cloudfoundry.org/cf-tcp-router 004af19..89625e5:

Use bin/test.bash for running tests (#15)
Submodule src/code.cloudfoundry.org/gorouter 31a88e6..587fdbd:
Use bin/test.bash for running tests (#357)
Submodule src/code.cloudfoundry.org/multierror 0623381..add4c8e:
Merge pull request #6 from cloudfoundry/with-bin/test.bash
Submodule src/code.cloudfoundry.org/route-registrar 247293e..958da78:
Use bin/test.bash for running tests (#35)
Submodule src/code.cloudfoundry.org/routing-api dd977026..84d22269:
Use bin/test.bash for running tests (#35)
Submodule src/code.cloudfoundry.org/routing-api-cli 045f777..5c9811f:
Use bin/test.bash for running tests (#16)
Submodule src/code.cloudfoundry.org/routing-info 079a2734..3a6d4ccb:
Use bin/test.bash for running tests (#5)


What is this change about?

In your own words, describe this proposed change and the problem it solves. If GitHub has prepopulated any text above here with info from your commit message, please clean it up and account for it in this section.

What type of change is this?

  • [Breaking Change]: the change removes a feature or introduces a behavior change to core functionality (request routing, request logging)
  • [Minor Feature/Improvement]: the change introduces a new feature or improvement that doesn't alter core behavior
  • [Bug Fix]: the change addresses a defect

If you have selected multiple of the above, it may be wise to consider splitting this PR into multiple PRs to decrease the time for minor changes + bugs to be resolved.

Backwards Compatibility

If this is a breaking change, or modifies currently expected behaviors of core functionality (request routing or request logging), how has the change been mitigated to be backwards compatible?

Should this feature be considered experimental for a period of time, and allow operators to opt-in? Should this apply immediately to all routing-release deployments?

How should this be tested?

Are there any non-automated tests that should be performed against this change for validation? Please provide steps, and expected results for before + after the change.

Additional Context

Please provide any additional links or context (issues, other PRs, Slack discussions) to help understand this change.

PR Checklist

bump gorouter
bump multierror
bump route-registrar
bump routing-api
bump routing-api-cli
bump routing-info

Submodule src/code.cloudfoundry.org/cf-tcp-router 004af19..89625e5:
  > Use bin/test.bash for running tests (#15)
Submodule src/code.cloudfoundry.org/gorouter 31a88e6..587fdbd:
  > Use bin/test.bash for running tests (#357)
Submodule src/code.cloudfoundry.org/multierror 0623381..add4c8e:
  > Merge pull request #6 from cloudfoundry/with-bin/test.bash
Submodule src/code.cloudfoundry.org/route-registrar 247293e..958da78:
  > Use bin/test.bash for running tests (#35)
Submodule src/code.cloudfoundry.org/routing-api dd977026..84d22269:
  > Use bin/test.bash for running tests (#35)
Submodule src/code.cloudfoundry.org/routing-api-cli 045f777..5c9811f:
  > Use bin/test.bash for running tests (#16)
Submodule src/code.cloudfoundry.org/routing-info 079a2734..3a6d4ccb:
  > Use bin/test.bash for running tests (#5)
@winkingturtle-vmw winkingturtle-vmw requested a review from a team as a code owner September 11, 2023 19:12
@winkingturtle-vmw winkingturtle-vmw merged commit 62c613d into develop Sep 11, 2023
@winkingturtle-vmw winkingturtle-vmw deleted the bump-repos branch September 11, 2023 19:49
Dariquest pushed a commit to sap-contributions/routing-release that referenced this pull request May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants