Skip to content

Conversation

@schmidtsv
Copy link
Contributor

@schmidtsv schmidtsv commented Mar 25, 2025

Description

One of the headers lacked a space between # and the Text, leading it to be rendered as normal text, not ad header.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack

Copy link

@chombium chombium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix @schmidtsv

@github-project-automation github-project-automation bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Mar 26, 2025
@ctlong ctlong merged commit 1c022bf into cloudfoundry:main Mar 26, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Mar 26, 2025
@ctlong
Copy link
Member

ctlong commented Mar 26, 2025

Thanks for taking the time to fix this!

@schmidtsv schmidtsv deleted the patch-1 branch March 26, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants