-
Couldn't load subscription status.
- Fork 50
Default pre-starts to use service instead of systemctl #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/cc @alchen1218 |
…rting with systemd - Defaulting to rsyslog until the majority, if not most, components move completely to noble+ stemcells enables the largest compatibility window
|
/cc @chombium |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally don't think that service, the fallback should be set as a default. The BOSH-Lite and Docker CPIs are full with hacks and on top of that the Docker CPI uses the Docker V1 API which is also deprecated. I guess with this PR we are only masking the root cause.
I've also started discussion on Slack in the BOSH channel to gather some experience what are the others doing in such cases.
Defaulting to service until the majority, if not most, components move completely to noble+ stemcells enables the largest compatibility window
@drich10 What do you expect to change with the noble stemcells?
|
@chombium I can appreciate that, but until that changes a breaking change in this release has made it unusable in our environments until a more general future path is chosen. I expect warden, cpis, and releases across the ecosystem will soon start tackling the broader noble compatibility, but we aren't near that being the default writ large. |
|
Just to give context, we use BOSH Lite with the docker CPI in CI extensively to make cloud costs more affordable, locally for developing components on our own machines, and even in other cool ways. So it's gonna be pretty bad for us (and the CFF) cost and productivity-wise if we can't continue to take this shortcut. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @drich10 for the change and @dsboulder for the explanation. I know that the Bosh-Lite and Docker CPIs are full of hacks to make things work on a local machine and I've rethought the whole problem. As we don't use some advanced systemctl calls, it should be ok if we change the defaults.
Please make sure that you tests everything on "real foundations" as well where systemd runs with pid = 1, so that we don't have any regressions.
Description
The current behavior breaks rsyslog when using the docker cpi and sta…rting with systemd
Type of change
Testing performed?
Manual testing on a docker cpi deployment. You can recreate the "broken rsyslog" state just by booting a warden stemcell with the
systemdoption in the docker cpi.Checklist:
mainbranch, or relevant version branch