Add Badge component, pencil icon, demo roles to Comment #1379
Conversation
🦋 Changeset detectedLatest commit: 9ec9af2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Paul-Hebert
left a comment
Paul-Hebert
left a comment
There was a problem hiding this comment.
This looks great! I've got one question inline about how we're exposing the pencil icon SVG to screen readers and other assistive tech.
| {% if icon %} | ||
| {% include '@cloudfour/components/icon/icon.twig' with { | ||
| name: icon | ||
| } only %} |
There was a problem hiding this comment.
I noticed the Firefox a11y inspector was complaining about this being an unlabeled image:
Since this is decorative should we add aria-hidden="true" or role="presentation"?
(FWIW this does read correctly in VoiceOver, but I wonder if it could lead to issues in other assistive technologies.)
There was a problem hiding this comment.
D'oh! This is an oversight on my part, thank you for pointing it out.
tylersticka
force-pushed
the
feature/c-badge
branch
from
616286a to
9ec9af2
Compare
Overview
pencilicon for "author" role badge in commentsScreenshots
Testing
On the deploy preview…