-
Notifications
You must be signed in to change notification settings - Fork 3
Add Feature Group object #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Feature Group object #1395
Conversation
🦋 Changeset detectedLatest commit: d6461c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks @tylersticka! I made a few changes 🙂
|
Co-authored-by: Gerardo Rodriguez <gerardo@cloudfour.com>
tylersticka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dromo77 I think you may also need to reduce or remove the grid-row-gap at larger sizes? I'm noticing that the gap is pushing the action down pretty low:
Here it is with grid-row-gap: 0 added at larger breakpoints:
@tylersticka I noticed that as well, this seems like a good solution! |
| import defaultDemoSource from '!!raw-loader!./demo/demo.twig'; | ||
| import defaultDemo from './demo/demo.twig'; | ||
|
|
||
| <Meta title="Objects/Feature Group" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this pattern depends on media queries, you should add parameters={{ docs: { inlineStories: false } }} to this Meta element. This will cause the stories to display in an iframe in Docs view.
tylersticka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉


Overview
This PR adds a Featured Row object. The pattern provides a layout for 3 main areas, a heading, content, and and optional cta.
Screenshots