Use font-display: swap in font declarations #1466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 24baa46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tylersticka
approved these changes
Aug 9, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a performance improvement, part of https://github.com/cloudfour/cloudfour.com-wp/issues/511.
font-display: swapmakes the browser display fallback fonts immediately, until the requested font is loaded. Without this property, the browser displays no text for a short delay, and only displays the fallback font after a timeout, and if the requested font has still not loaded after the timeout.Testing
I tested it on cloudfour.com locally by editing the font declarations in the node_modules folder. By repeatedly doing a hard-refresh with caching disabled, I could see that with
font-display: swapthe fallback font gets displayed right away.