Two o-rhythm improvements #1471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1b65b63 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
AriannaChau
previously approved these changes
Aug 9, 2021
Contributor
AriannaChau
left a comment
AriannaChau
left a comment
There was a problem hiding this comment.
It looks good to me.
calebeby
reviewed
Aug 9, 2021
calebeby
approved these changes
Aug 9, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
While providing feedback for @AriannaChau's article prototype, I became aware of two issues with
o-rhythm:o-rhythm--defaultmodifier for this purpose.--generous-headingsmodifier was ineffective onc-headingelements. In this PR, I've added a[class*='heading']selector to the vertical spacing mixin to serve this purpose in an extensible way.Screenshots
These screenshots both show an
o-rhythm--generous-headingselement with a plainh2and ac-headingof the same level. The spacing before each should be equal.Before
After