Skip to content

Add o-deck--4-column modifiers #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2021
Merged

Add o-deck--4-column modifiers #1480

merged 1 commit into from
Aug 12, 2021

Conversation

@tylersticka
Copy link
Member

@tylersticka tylersticka commented Aug 12, 2021

Overview

See title.

Screenshots

Screen Shot 2021-08-12 at 9 22 22 AM

/CC @AriannaChau

@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2021

🦋 Changeset detected

Latest commit: 1c33cb9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudfour/patterns Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tylersticka tylersticka marked this pull request as ready for review August 12, 2021 16:31
@tylersticka tylersticka requested review from a team August 12, 2021 16:31
AriannaChau
AriannaChau approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@AriannaChau AriannaChau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loooooooks good to me

@calebeby
Copy link
Member

calebeby commented Aug 12, 2021

@tylersticka This may or may not be relevant for this PR, but in the canvas view for Deck > Basic, the columns slider appears in the controls panel, but it doesn't actually do anything. Should we remove the slider for that story and only have it for the other two?

@tylersticka
Copy link
Member Author

tylersticka commented Aug 12, 2021

Should we remove the slider for that story and only have it for the other two?

Probably, though I'm going to leave it be for the moment since there are plenty of potential improvements to our controls that I can see.

@tylersticka tylersticka merged commit eeefd4e into v-next Aug 12, 2021
@tylersticka tylersticka deleted the feature/o-deck--4-column branch August 12, 2021 17:52
@github-actions github-actions bot mentioned this pull request Aug 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calebeby calebeby calebeby approved these changes

+1 more reviewer

@AriannaChau AriannaChau AriannaChau approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add 4-column modifiers to o-deck

4 participants

@tylersticka @calebeby @AriannaChau