Skip to content

Conversation

@tylersticka
Copy link
Member

Overview

The team page prototypes called for increasing the vertical padding of o-container, but in practice this had some unintentional consequences. I also noticed that this would only solve for one element's unique spacing requirements, when the same need befell several elements per prototype.

So this PR expands our existing spacing utilities to include responsive variations, as that was the only capability of the existing prototype CSS that wasn't possible before.

Screenshots

responsive-spacing


/CC @AriannaChau

@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2021

🦋 Changeset detected

Latest commit: f10796e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudfour/patterns Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tylersticka tylersticka marked this pull request as ready for review August 13, 2021 17:09
@tylersticka tylersticka requested review from a team August 13, 2021 17:09
Copy link
Member

@gerardo-rodriguez gerardo-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tylersticka tylersticka merged commit 19ecb0c into v-next Aug 16, 2021
@tylersticka tylersticka deleted the feature/tweak-container-padding branch August 16, 2021 16:10
@github-actions github-actions bot mentioned this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase vertical padding for container object

3 participants