Add subheading support to Heading #1489
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors our heading component class and template to accept a
subheadingoption.It differs slightly from the prototype in that the subheading has a
mediumfont weight instead ofnormalbecause I thought that made the two segments of the heading appear more closely related.The reasons for the refactor are as follows:
contentandsubheadingoptions may be properties or blocks, I found it necessary to add some additionalmakeTwig*utility functions for defining thetemplateSourceintelligently.I marked this as a
minorchange because the template syntax has not changed.See the docs and code comments for specific implementation details.
Screenshots
Testing
On the deploy preview...
/CC @dromo77 @calebeby