CSS text utility classes #1499
Merged
CSS text utility classes #1499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ecf238c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✔️ Deploy Preview for cloudfour-patterns ready! 🔨 Explore the source changes: ecf238c 🔍 Inspect the deploy log: https://app.netlify.com/sites/cloudfour-patterns/deploys/61268be647e89e00086bba6a 😎 Browse the preview: https://deploy-preview-1499--cloudfour-patterns.netlify.app |
tylersticka
requested changes
Aug 24, 2021
Member
tylersticka
left a comment
tylersticka
left a comment
There was a problem hiding this comment.
Please use BEMIT naming conventions rather than SUIT. (Kebab-case instead of camel-case.)
tylersticka
reviewed
Aug 25, 2021
tylersticka
approved these changes
Aug 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces two text utility CSS classes:
u-text-no-wrapu-text-actionThere was a question in the original issue whether these should be a new pattern or CSS utility classes. I opted for CSS utility classes because it felt like a bit too heavy-handed to go the component pattern route.
I'm open for discussion, though, if I am missing more context. 😉
Screenshots
Testing