fix: overlays special characters encoding for multiple occurrences #240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the
textcontains multiple occurrences of special characters (".", ",", and "/"in our case), only the first occurrence was being replaced with the corresponding encoding because thereplace()function was used. I have updated it to usereplaceAll()which fixes this issue. I have also updated our test for text with special characters to ensure this case is covered.Issue Ticket Number
Fixes #233
Type of change
Checklist